This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
Read the collection config in the deploy webview #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cypress use ESNext lib inline with UI compiler Signed-off-by: James Wallis <j@wallis.dev>
james-wallis
force-pushed
the
2948-read-collections-clientside-2
branch
from
f1d5e4f
to
7f3c22f
Compare
james-wallis
changed the title
|
I've been able to test this using a private TypeScript smart contract generated before we moved to use implicit collections in generator-fabric. Everything looks good.
I'll attach the contract here for the reviewer. |
Jakeeyturner
approved these changes
Mar 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2948 describes a bug where when using remote workspaces the collection file is being chosen on the users desktop but when the smart contract is deployed, we try to find it on the remote computer.
Reading the collection config file on the webview side should fix this issue (as opposed to passing its path to the extension and reading it there).
Signed-off-by: James Wallis j@wallis.dev