Update K8s cluster deployment #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
roytman
reviewed
Jun 25, 2024
scripts/k8s-setup/Makefile
Outdated
| @echo EXTERNAL_CLUSTER - If 0 create a KinD cluster. EXTERNAL_CLUSTER=$(EXTERNAL_CLUSTER) | ||
| @echo DEPLOY_KUBEFLOW - If 1 deploy kubeflow pipelines on the cluster. DEPLOY_KUBEFLOW=$(DEPLOY_KUBEFLOW) | ||
| @echo USE_KFP_MINIO - If 1 and DEPLOY_KUBEFLOW is also 1 then deploy MinIO on the cluster including ingress to access it. USE_KFP_MINIO=$(USE_KFP_MINIO) | ||
| @echo POPULATE_TEST_DATA - If 1 populate test data to MinIO. POPULATE_TEST_DATA=$(POPULATE_TEST_DATA) |
There was a problem hiding this comment.
we can use an external Minio Server $MINIO_SERVER, but maybe better to define an S3 server and provide its username and password, see "populate_minio.sh"
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
revit13
force-pushed
the
kind13
branch
2 times, most recently
from
f77a9f9
to
cc5166c
Compare
daw3rd
reviewed
Jun 25, 2024
daw3rd
previously requested changes
Jun 25, 2024
revit13
force-pushed
the
kind13
branch
2 times, most recently
from
128de1c
to
78d1ff7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
/Closes #326
Related issue number (if any).
#326