Skip to content

Add TLS cipher suites in the mount options #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 4, 2025
Merged

Add TLS cipher suites in the mount options #263

merged 18 commits into from
Sep 4, 2025

Conversation

ashimagarg27
Copy link
Member

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have made sure existing UTs are not impacted
  • I have executed all necessary linter and made sure internal pipeline/travis is not broken

@ashimagarg27
update versions
8ab9b8d 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
da5f6b8 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
a277cd4 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
c702caa 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
50f7fdd 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
publish v0.9.2
5a920f9 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
d9b9633 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
publish v0.9.6
6df7f69 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
d4d577b 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
a62cffa 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
Bhagyashreek8
Bhagyashreek8 previously approved these changes Sep 2, 2025
View reviewed changes
Copy link
Collaborator

@Bhagyashreek8 Bhagyashreek8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mssachan
mssachan requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments.

@ashimagarg27
renaming
21a139b 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
b74a87b 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
4598a10 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
7ecbf14 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
a4eb94f 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
set cipher suites from secrets in mount options
9119859 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
@ashimagarg27
uts
83de57f 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
mssachan
mssachan requested changes Sep 4, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good. Added minor comments. PTAL.

@ashimagarg27
set cipher suites from secrets in mount options
d99f8ce 
Signed-off-by: Ashima-Ashima1 <Ashima.Ashima1@ibm.com>
mssachan
mssachan approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@mssachan mssachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashimagarg27 ashimagarg27 merged commit 0c34060 into main Sep 4, 2025
3 checks passed
@ashimagarg27 ashimagarg27 deleted the ciphersuites branch September 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mssachan mssachan mssachan approved these changes

@Bhagyashreek8 Bhagyashreek8 Bhagyashreek8 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashimagarg27 @mssachan @Bhagyashreek8