Remove emptyDir build-volume from mlx-ui
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changes to the mlx-ui Docker image, we no longer require the externally mounted build volume Related: machine-learning-exchange/mlx#339 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
Thanks @jbusche for testing this on OpenShift on Fyre |
yhwang
approved these changes
Jun 15, 2022
|
I will merge it after the change in mlx |
|
Thanks @yhwang |
|
rebased the change to v1.5-branch |
yhwang
pushed a commit
that referenced
this pull request
Aug 10, 2023
After changes to the mlx-ui Docker image, we no longer require the externally mounted build volume Related: machine-learning-exchange/mlx#339 Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
After changes to the mlx-ui Docker image, we no longer require the externally mounted build volume
/cc @Tomcli @yhwang
FYI @jbusche
Checklist:
Make sure you have installed kustomize == 3.2.1
make generate-changed-onlymake test