Finalizing optimized HC set #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom connectivity properties. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…ding to more condensed optimized output. Signed-off-by: Tanya <tatyana@il.ibm.com>
…to account TCP/non-TCP protocol restriction. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
reviewed
Mar 12, 2024
| if diff_prop.are_auto_conns(): | ||
| print(f"{text_prefix} differ only in auto-connections") | ||
| else: | ||
| print(f"Error: {text_prefix} are different") | ||
| assert False | ||
|
|
||
| @staticmethod | ||
| def compare_fw_rules_to_conn_props(fw_rules, props, peer_container, connectivity_restriction=None): |
There was a problem hiding this comment.
does it run on debug or optimized flag?
after removing optimized flag, should be run on "new debug mode" , to be run on tests only
There was a problem hiding this comment.
Checked, it runs both on -opt=debug and -opt=true.
| else: # connectivity_restriction == 'non-TCP' | ||
| relevant_protocols = ProtocolSet.get_non_tcp_protocols() | ||
|
|
||
| peers_to_connections = defaultdict(ConnectionSet) |
There was a problem hiding this comment.
why ConnectionSet and not ConnectivityProperties?
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping. Signed-off-by: Tanya <tatyana@il.ibm.com>
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…e properties in containing connections. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping. Added grouping by full IpBlock. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
…neration of dot output in optimized solution Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
reviewed
Apr 9, 2024
Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of building and minimizing fw-rules directly from connectivity properties.