Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized HC-set finalization - changing expected results #712

Merged
merged 75 commits into from
May 5, 2024
Merged

Optimized HC-set finalization - changing expected results #712

merged 75 commits into from
May 5, 2024

Conversation

tanyaveksler
Copy link
Member

No description provided.

@tanyaveksler
Initial implementation of building and minimizing fw-rules directly f…
8e368e0 
…rom connectivity properties.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixed lint errors.
8240404 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Merge branch 'master' into opt-finalize
5ad1ee9
@tanyaveksler
Updating (some of) expected results for explainability queries, accor…
6466889 
…ding to more condensed optimized output.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixed converting fw-rules to connectivity properties, while taking in…
a615f5c 
…to account TCP/non-TCP protocol restriction.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Optimized handling IpBlocks in optimized fw-rules minimization
9c5e89a 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Optimized initial namespace grouping (by grouping few namespaces toge…
81ac68f 
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Optimized initial namespace grouping (by grouping few namespaces toge…
06f5250 
…ther, according to grouping in cubes). Also, added grouping by labels to initial grouping.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
More optimization in calculation partial ns grouping.
898f222 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixed lint error
ae2ff0a 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Refining basic namespace grouping by finding more opportunities to us…
06b2905 
…e properties in containing connections.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
One more refinemenet of basic namespace grouping
6b22688 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
One more refinemenet of basic namespace grouping
368f1b0 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
More refinemenets of peer grouping from properties
d027631 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
More refinemenets of peer grouping from properties
8b343d6 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
More refinements of peer grouping from properties
0bb3094 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Added outputEndpoints option handling to PeerSetElement.
0df3938 
Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping.
Added grouping by full IpBlock.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing lint errors.
4db0e43 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing handling txt-no_fw_rules format in the optimized solution
757a684 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing lint error
1efde22 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fix: taking into account connectivity restriction (TCP/non-TCP) in ge…
86af435 
…neration of dot output in optimized solution

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Small fixes in txt_no_fw_rules_format
8bd2944 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Small fixes in txt_no_fw_rules_format
0bd08c3 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Added grouping by dns entries to the optimized algorithm.
b01e93d 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Changed expected results of connectivity map query tests according to…
316dee1 
… optimized runs

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Changed optimized semantic diff query implementation according to the…
e5eb701 
… optimized fw-rules minimization algorithm.

Fixed get_connection_set_and_peers_from_cube.
Changed some of the expected results of semantic diff tests.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Keeping every dns entry separate in minimization of fw rules.
5c0cc0c 
Updated more semantic diff expected results.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Updated containment, permits, forbids expected results.
f8f1d67 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Cleaning up unused code and refactoring accordingly.
eaf561d 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Merge branch 'master' into opt-finalize
d6633e4
@tanyaveksler
More refinemenets of peer grouping from properties
4203525 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
More refinements of peer grouping from properties
62aa803 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Added outputEndpoints option handling to PeerSetElement.
70d2aaf 
Refined ns-set pairs grouping computation -trying starting from src_peers and from dst_peers and choosing a more compact grouping.
Added grouping by full IpBlock.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing lint errors.
a98798f 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing handling txt-no_fw_rules format in the optimized solution
a5c9808 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixing lint error
43d2e5b 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fix: taking into account connectivity restriction (TCP/non-TCP) in ge…
36edddf 
…neration of dot output in optimized solution

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Small fixes in txt_no_fw_rules_format
91f13ff 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Small fixes in txt_no_fw_rules_format
55b2786 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Added grouping by dns entries to the optimized algorithm.
05de16f 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Changed expected results of connectivity map query tests according to…
9ad18b1 
… optimized runs

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Changed optimized semantic diff query implementation according to the…
c11a3ae 
… optimized fw-rules minimization algorithm.

Fixed get_connection_set_and_peers_from_cube.
Changed some of the expected results of semantic diff tests.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Keeping every dns entry separate in minimization of fw rules.
f591e4f 
Updated more semantic diff expected results.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Updated containment, permits, forbids expected results.
5e5b1a4 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Cleaning up unused code and refactoring accordingly.
5817b22 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Fixed lint error.
1379379 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Changed default to be the optimized run.
8a0d7f2 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
In opt='debug' the result explanation should ne according to the opti…
91a6298 
…mized run.

Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Restoring resource in scheme, changed by mistake.
7aaa0ba 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Updating more expected results.
f7cc420 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Small optimizations.
43bb6f4 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Merge remote-tracking branch 'origin/opt-finalize2' into opt-finalize2
0334ec1
@tanyaveksler tanyaveksler reopened this Apr 16, 2024
@tanyaveksler
Small optimizations.
d71e51f 
Signed-off-by: Tanya <tatyana@il.ibm.com>
@tanyaveksler
Merge branch 'master' of https://github.com/IBM/network-config-analyzer…
cb54265 
… into opt-finalize2
@tanyaveksler tanyaveksler requested a review from adisos April 16, 2024 11:10
adisos
adisos approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!
LGTM

@tanyaveksler tanyaveksler merged commit bc23aca into master May 5, 2024
16 checks passed
@tanyaveksler tanyaveksler deleted the opt-finalize2 branch May 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees

@tanyaveksler tanyaveksler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanyaveksler @adisos