Skip to content

test: Check the XMLSERVICE version for QSH support #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2020
Merged

test: Check the XMLSERVICE version for QSH support #303

merged 3 commits into from
Dec 7, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 20, 2020

Fixes #193

@abmusse abmusse force-pushed the check-xmlservice-version-for-qsh branch from b155eb8 to 625e3f5 Compare July 20, 2020 21:07
@abmusse abmusse marked this pull request as ready for review July 20, 2020 21:07
@abmusse abmusse requested a review from kadler July 20, 2020 21:07
@abmusse abmusse marked this pull request as draft July 20, 2020 21:25
@abmusse abmusse force-pushed the check-xmlservice-version-for-qsh branch from 1d3dd85 to 90c6d55 Compare July 20, 2020 21:40
@abmusse abmusse force-pushed the check-xmlservice-version-for-qsh branch from 90c6d55 to 1e4f586 Compare July 20, 2020 21:42
@abmusse abmusse marked this pull request as ready for review July 20, 2020 21:54
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 20, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 20, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
kadler
kadler approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadler kadler merged commit 9067616 into master Dec 7, 2020
@kadler kadler deleted the check-xmlservice-version-for-qsh branch December 7, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
keep-open Exempts stale action from auto closing the issue/pr. stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QSH Command tests fail with XMLSERVICE < 1.9.8
2 participants
@abmusse @kadler