-
Notifications
You must be signed in to change notification settings - Fork 38
build: Update deps for security #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
After Running npm audit fix there we still issues that require manual intervetion because of SEMVER Warnings
We should probably just update eslint and mocha to the latest versions. This would require ensuring that the test cases dont break with the major SEMVER change. |
Manually applied the following fixes: - npm install --save-dev mocha@9.2.0 - npm install --save-dev eslint@8.8.0
Applied the following manually fixes:
$ npm audit
=== npm audit security report ===
found 0 vulnerabilities
Both unit and functional tests run fine with mochajs 9.2.0 Although now with eslint 8.8.0 running the linter has problems: See https://github.com/IBM/nodejs-itoolkit/runs/5025626973?check_suite_focus=true UPDATE: The error above is expected because eslint-plugin-import is not yet compatible with eslint v8. See import-js/eslint-plugin-import#2251 (comment). Therefore will downgrade eslint to latest of version 7.x.x to fix this. |
OK with downgrading eslint we got past the |
OK d6dd40d fixed the lint errors. |
Closing in favor of #347 |
Ran
npm audit
andnpm audit fix
locally to update bunch of dev deps: