Docs: Reference alternate XML parser #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmusse
reviewed
Oct 13, 2022
|
Can you sign-off the commits to appease the DCO bot https://github.com/IBM/nodejs-itoolkit/pull/345/checks?check_run_id=7364528303 Thanks again! |
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
…uide Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
Signed-off-by: Wyatt Teeter <teeterwyatt@gmail.com> Signed-off-by: xWyatt <wteeter@ppi-global.com>
xWyatt
force-pushed
the
chore/docsReferenceAltXMLParser
branch
from
a16102a
to
99bcf95
Compare
|
I tacked on sign-offs with my Github username to the commits as opposed to my profile name. That should appease the DCO bot - interesting that it won't accept the profile name in the first place though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates documentation, documentation code samples, and the
xmlToJsondeprecation message to suggest the use offast-xml-parseroverxml2js.Previous issues, confusion, and lack of maintenance of
xml2jsoutlined in #344 lead to this PR.