Skip to content

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Apr 6, 2022

PR summary

adding new endpoints: create report, get report
adding new optional query parameter include_activity for the existing get calls of apikey/serviceid/profile by id.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

users will now be able to generate report for inactive identities.
create report: will return a reference
get report: this will return a detailed report of inactive identities
existing get apikey/serviceid/profile by id will now include additional optional parameter include_activity
if include_activity is passed as true the response will include a new section activity with last authn time and count.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2022-04-06 at 09 42 33

@pooraniss-ibm pooraniss-ibm requested a review from padamstx April 6, 2022 08:45
@padamstx padamstx self-assigned this Apr 6, 2022
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-adding-activity branch from 18a33a8 to dcd86ae Compare April 6, 2022 14:55
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-adding-activity branch from dcd86ae to e5e1951 Compare April 6, 2022 15:24
@padamstx padamstx merged commit d748f00 into main Apr 6, 2022
@padamstx padamstx deleted the iam-identity-adding-activity branch April 6, 2022 19:35
ibm-devx-sdk pushed a commit that referenced this pull request Apr 6, 2022
# [0.24.0](v0.23.0...v0.24.0) (2022-04-06)

### Features

* **IAM Identity:** add support for inactivity reports ([#155](#155)) ([d748f00](d748f00))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants