chore: add black code formatter to the project
#179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
pyrooka
force-pushed
the
nb/add-black-formatter
branch
2 times, most recently
from
c42a87b to
ad8833c
Compare
Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com> This reverts commit ad8833c.
pyrooka
force-pushed
the
nb/add-black-formatter
branch
from
a855a31 to
23b9905
Compare
This reverts commit 23b9905. Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
|
I ended up choosing the lazy way (revertception?) to fix the builds. |
What is a "revertception"? 😂 |
|
🎉 This PR is included in version 0.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This commit adds the Black code formatter to the project
and updates the
Makefileto use it. There are 2 targets that run theblacktool:make lint: this will check the code with bothpylintandblackmake lint-fix: this will reformat the code usingblack.It also re-formats the Python file by running
make lint-fix.PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information