Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sub project scanning to be user invoked #574

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

SanjulaGanepola
Copy link
Collaborator

No description provided.

Signed-off-by: Sanjula <Sanjula.Ganepola@ibm.com>
Copy link

github-actions bot commented Sep 3, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

package.json Outdated Show resolved Hide resolved
Signed-off-by: Sanjula <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola changed the title Set default scan depth to 0 and improve error message Make sub project scanning to be user invoked Oct 23, 2024
// Scan for subprojects
const projectScanDepth = ConfigurationManager.get(ConfigurationSection.projectScanDepth);
const scanDepth = projectScanDepth && typeof projectScanDepth === 'number' ? projectScanDepth : 2;
const scanDepth = projectScanDepth && typeof projectScanDepth === 'number' ? projectScanDepth : 0;
if (scanDepth === 0) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the minimum is set to 1 in the package.json, we still check if it is set to 0 in case the user manually did this in the settings.json

@edmundreinhardt edmundreinhardt merged commit 6b9bd33 into main Oct 23, 2024
6 checks passed
@edmundreinhardt edmundreinhardt deleted the fix/scan-depth-check branch October 23, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants