update zos script sample playbook #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com>
richp405
approved these changes
Aug 27, 2024
| @@ -11,18 +11,22 @@ | |||
| # | |||
| # Example: | |||
| # ansible-playbook -i inventories zos_script.yml | |||
| # ansible-playbook -i inventories zos_script.yml --tags rexx_script | |||
There was a problem hiding this comment.
I didn't know about the tags, it is a nice of overloading the playbook but probably a new user won't know them either, maybe you can add a small hint that if user wants to just execute rexx script section he can use this command.
| # The task also passes in a command line arg like the previous one did. | ||
| # The 'executable' module option enables running other types of scripts by | ||
| # passing in a path to the appropriate executable. The Ansible inventory | ||
| # variable 'ansible_python_interpreter' is typically used to specify the |
There was a problem hiding this comment.
isn't it always true instead of tipically?
There was a problem hiding this comment.
hmm, good point. I'll change it
My initial thinking was that the "typical" use was to tell ansible-core where remote python is, but since it's used in this playbook task to tell zos_script where remote python is, that would be an a-typical' use.
Signed-off-by: Ketan Kelkar <ktnklkr@gmail.com>
ketankelkar
added
the
Branch: Do not Merge
ketankelkar
removed
the
Branch: Do not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of this sample playbook was well done. It showed off 3 significant "features" of the
zos_scriptmodule via 3 separate tasks - command line args, module optionschdir/executable, and jinja-templated scripts.I've kept a similar structure as above and have introduced blocks to separate the 3 groups. The first itemis a hello-world Rexx script which parses a command line arg
nameand prints out "Helloname" and the current working directory. The second item is a hello-world python script which does much the same as the Rexx script, reading a command line arg, printing out a "hello " message and printing out the 'current working directory'; but this item also requires theexecutableto be set and also showcases thechdiroption. The user is invited to compare the 'current working directories' printed by the first two items.The third item is a jinja-templated shell script. Three types of templating features are showcased in this script. First is a simple string substitution, i.e
echo "Hello {{ ansible_user }}". The next is a conditional statement, and finally two types of loops -- over a range and through a list.I trust that the descriptions included in the playbook tasks and comments are well-written and offer clarity, please do point out any areas which could use any amount of improvement