Feature modelselection visualization #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
erikadudki
commented
May 11, 2020
erikadudki
commented
- function to plot AIC or BIC from a model-selection result object
- add example in jupyter-notebook
erikadudki
requested review from
plakrisenko,
LeonardSchmiester,
yannikschaelte,
MerktSimon,
dilpath and
LarsFroehling
pypesto/visualize/model_selection.py
Outdated
| def plot_modelselection( | ||
| selection_history : dict, | ||
| aic_or_bic : str = 'AIC', | ||
| option : str = 'delta', |
There was a problem hiding this comment.
hard to find a meaningful name. option -> mode?
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
pypesto/visualize/model_selection.py
Outdated
Comment on lines
110
to
112
| # ----------------------------------------------------- | ||
| # example | ||
| # selection_history = { |
There was a problem hiding this comment.
@erikadudki remove the comments, then good to merge?
yannikschaelte
approved these changes
May 13, 2020
m-philipps
pushed a commit
that referenced
this pull request
Jun 14, 2022
* visualization: allow for optional columns * add test for minimal visu spec file * non-mandatory columns in measurement file are handled in visu routine * new test cases for minimal measurement file, only mandatory columns * add error: xvalues in visu file is mandatory Closes #165, closes #333, closes #329, closes #326, closes #320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.