-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
account for plist in edata when slicing amici results #621
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #621 +/- ##
===========================================
- Coverage 88.16% 87.50% -0.67%
===========================================
Files 79 93 +14
Lines 5257 5890 +633
===========================================
+ Hits 4635 5154 +519
- Misses 622 736 +114
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. maybe just wait for next amici release?
"""Test that the AMICI objective created via PEtab correctly maps | ||
gradients entries when some parameters are not estimated (realized via | ||
edata.plist).""" | ||
model_name = "Boehm_JProteomeRes2014" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boehm has 2 fixed parameters at -1, -5, therefore this should be a good example 👍
Co-authored-by: Yannik Schälte <31767307+yannikschaelte@users.noreply.github.com>
requires AMICI-dev/AMICI#1487