-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes steadystate guesses #715
Conversation
FFroehlich
commented
Jul 27, 2021
- reinitialize objective during startpoint resampling to avoid using steadystate guesses.
- fix shape bug introduced via construct condition specific plist in parameter mapping AMICI-dev/AMICI#1487 and account for plist in edata when slicing amici results #621
- fix check for elementwise changes in linear updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me if tests pass. re-initializing in startpoint method certainly makes sense.
…pyPESTO into fix_steadystate_guesses
Codecov Report
@@ Coverage Diff @@
## develop #715 +/- ##
============================================
+ Coverage 46.38% 88.08% +41.69%
============================================
Files 96 96
Lines 6521 6523 +2
============================================
+ Hits 3025 5746 +2721
+ Misses 3496 777 -2719
Continue to review full report at Codecov.
|