Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the SPITZER-YAAAR data format, should we split up the modules further? #33

Closed
ciskakemper opened this issue May 20, 2021 · 3 comments
Assignees

Comments

@ciskakemper
Copy link
Collaborator

Maybe @pscicluna has some insight in this one.

When reading in SPITZER-YAAAR data formats in data.py, the data is divided into chunks, by module. The data has four modules, corresponding to SL1, SL2, LL1 and LL2, but not in that order. In fact, the order is:

module wavelength name
0 7.5 - 14.0 SL2
1 5.2 - 8.3 SL1
2 20.6 - 37.5 LL2
3 14.1 - 21.4 LL1

Currently, the data is divided into two chunks, SL and LL, using the module information in the data file (e.g. (0 or 1) and (2 or 3)), but in that case, the chunks internally are not ordered by wavelength. Should we perhaps divide the data in four chunks, and order the chunks by wavelength?

@ciskakemper
Copy link
Collaborator Author

Oh, right, I see. There is some overlap between SL1 and SL2, and the same for LL1 and LL2. Splitting them up completely would not result in an ordered table. So my question is, why do we divide this data into two chunks to begin with. Can we not apply sort on the entire table?

@pscicluna
Copy link
Contributor

pscicluna commented May 20, 2021 via email

@ciskakemper
Copy link
Collaborator Author

This makes a lot of sense. SL1 and SL2 are indeed observed by projection on the same detector array at the same time, and the same for LL1 and LL2. You basically have two detector array images with the spectra projected on it. Thus SL and LL are independent measurements but the different orders within each module are not. I think we can close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants