Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code references to gas solid contactors docs #1451

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

bpaul4
Copy link
Contributor

@bpaul4 bpaul4 commented Jul 15, 2024

Fixes

Clarifies code reference requested by #1446.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.35%. Comparing base (80d37a8) to head (889e58c).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
- Coverage   76.36%   76.35%   -0.01%     
==========================================
  Files         394      394              
  Lines       64953    64953              
  Branches    14404    14404              
==========================================
- Hits        49601    49598       -3     
- Misses      12793    12797       +4     
+ Partials     2559     2558       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Jul 18, 2024
Copy link
Contributor

@MarcusHolly MarcusHolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl
Copy link
Contributor

@aostace01 do you think you have time for a quick review? There are just a few changes in the docs.

Copy link
Contributor

@aostace01 aostace01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) July 25, 2024 23:00
@ksbeattie ksbeattie disabled auto-merge August 1, 2024 18:30
@ksbeattie ksbeattie merged commit 94a3043 into IDAES:main Aug 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants