bugfix: failed to obtain frameSize when open rawfile #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: for13to1 <for13to1@outlook.com>
| @@ -278,7 +278,7 @@ struct Size | |||
| { | |||
| return this->width != other.width || this->height != other.height; | |||
| } | |||
| constexpr bool isValid() const { return this->width != 0 && this->height != 0; } | |||
| constexpr bool isValid() const { return this->width > 0 && this->height > 0; } | |||
There was a problem hiding this comment.
This is equal to the old code. The problem is the static cast further up.
There was a problem hiding this comment.
This style can work both on signed or unsigned integer type definition: only positive values are valid, which means it allow using signed interger declaration.
Comment on lines
+567
to
+578
| allExtensions.append("rgba"); | ||
| allExtensions.append("rbga"); | ||
| allExtensions.append("grba"); | ||
| allExtensions.append("gbra"); | ||
| allExtensions.append("brga"); | ||
| allExtensions.append("bgra"); | ||
| allExtensions.append("argb"); | ||
| allExtensions.append("arbg"); | ||
| allExtensions.append("agrb"); | ||
| allExtensions.append("agbr"); | ||
| allExtensions.append("abrg"); | ||
| allExtensions.append("abgr"); |
There was a problem hiding this comment.
Do you think these are missing? This was not metioned in the issue.
There was a problem hiding this comment.
I will open another issue, since I found YUView supports RGB image with alpha channel.
With these appending, opening *.rgba files will be more convenient.
|
I am not sure about the RGB file extensions but there was no issue for this so closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#547