-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: failed to obtain frameSize when open rawfile #548
Conversation
Signed-off-by: for13to1 <for13to1@outlook.com>
@@ -278,7 +278,7 @@ struct Size | |||
{ | |||
return this->width != other.width || this->height != other.height; | |||
} | |||
constexpr bool isValid() const { return this->width != 0 && this->height != 0; } | |||
constexpr bool isValid() const { return this->width > 0 && this->height > 0; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is equal to the old code. The problem is the static cast further up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This style can work both on signed or unsigned integer type definition: only positive values are valid, which means it allow using signed interger declaration.
allExtensions.append("rgba"); | ||
allExtensions.append("rbga"); | ||
allExtensions.append("grba"); | ||
allExtensions.append("gbra"); | ||
allExtensions.append("brga"); | ||
allExtensions.append("bgra"); | ||
allExtensions.append("argb"); | ||
allExtensions.append("arbg"); | ||
allExtensions.append("agrb"); | ||
allExtensions.append("agbr"); | ||
allExtensions.append("abrg"); | ||
allExtensions.append("abgr"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think these are missing? This was not metioned in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open another issue, since I found YUView supports RGB image with alpha channel.
With these appending, opening *.rgba files will be more convenient.
I am not sure about the RGB file extensions but there was no issue for this so closing this for now. |
#547