Update dref status #2551
Draft
Update dref status #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudip-khanal
requested review from
susilnem,
szabozoltan69 and
frozenhelium
and removed request for
susilnem and
szabozoltan69
susilnem
requested changes
Sep 12, 2025
dref/migrations/0084_alter_dref_status_alter_dreffinalreport_status_and_more.py
Show resolved
Hide resolved
| ) | ||
| def get_published(self, request, pk=None, version=None): | ||
| dref = self.get_object() | ||
| if dref.status != Dref.Status.FINALIZED: |
There was a problem hiding this comment.
We should add validation in serializer to enforce allowed status transitions for post and update. It's fine for publish api.
Draft-> FINALIZED.
FINALIZED-> draft
FINALIZED -> Approved
susilnem
requested changes
Sep 18, 2025
dref/serializers.py
Outdated
|
|
||
| def get_unpublished_op_update_count(self, obj) -> int: | ||
| return DrefOperationalUpdate.objects.filter(dref_id=obj.id, is_published=False).count() | ||
| return DrefOperationalUpdate.objects.filter(dref_id=obj.id, status=Dref.Status.DRAFT).count() |
There was a problem hiding this comment.
Suggested change
| return DrefOperationalUpdate.objects.filter(dref_id=obj.id, status=Dref.Status.DRAFT).count() | |
| return DrefOperationalUpdate.objects.filter(dref_id=obj.id, status!=Dref.Status.APPROVED).count() |
dref/serializers.py
Outdated
|
|
||
| def get_unpublished_final_report_count(self, obj) -> int: | ||
| return DrefFinalReport.objects.filter(dref_id=obj.id, is_published=False).count() | ||
| return DrefFinalReport.objects.filter(dref_id=obj.id, status=Dref.Status.DRAFT).count() |
6 tasks
sudip-khanal
force-pushed
the
feat/update-dref-status
branch
from
51f3e24 to
f31e649
Compare
sudip-khanal
force-pushed
the
feat/update-dref-status
branch
2 times, most recently
from
89a6cb8 to
7bebad0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Depends on
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.