-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IGVF-31 Implement a global context for the site and page titles #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forresttanaka
added a commit
that referenced
this pull request
Mar 8, 2022
# This is the 1st commit message: IGVF-35-cypress-circleci Try the cypress orb. # This is the commit message #2: Revert "IGVF-35-cypress-circleci" This reverts commit fa1521f. # This is the commit message #3: IGVF-35-cypress-circleci Revert last change and try a different tactic using docker-compose.test.yml. # This is the commit message #4: Revert "IGVF-35-cypress-circleci" This reverts commit 2e7ad9c. # This is the commit message #5: IGVF-35-cypress-circleci Another attempt to run Cypress in CircleCI. # This is the commit message #6: IGVF-35-cypress-circleci Alter previous attempt. # This is the commit message #7: IGVF-35-cypress-circleci Try two docker-compose files; one specifically for cypress. # This is the commit message #8: IGVF-35-cypress-circleci Possibly the wrong command to start Cypress. # This is the commit message #9: IGVF-35-cypress-circleci Try to solve EACCES error for Cypress cache. # This is the commit message #10: IGVF-35-cypress-circleci Try setting environment variable for Cypress in through the docker-compose file. # This is the commit message #11: IGVF-35-cypress-circleci Fix error setting the environment variable from the last fix. # This is the commit message #12: IGVF-35-cypress-circleci Try a different cypress cache directory # This is the commit message #13: IGVF-35-cypress-circleci Everyone seems to recommend a different syntax. Here’s yet another. # This is the commit message #14: IGVF-35-cypress-circleci Downgrading node in case cypress-io/cypress#15025 is correct. # This is the commit message #15: IGVF-35-cypress-circleci Try apt-get for cypress dependencies. # This is the commit message #16: Revert "IGVF-35-cypress-circleci" This reverts commit f7b66a5. # This is the commit message #17: IGVF-35-cypress-circleci Try using the Cypress orb. # This is the commit message #18: IGVF-35-cypress-circleci Start the server before starting the Cypress tests. # This is the commit message #19: IGVF-35-cypress-circleci Correction to last commit. Options can have very subtle effects on required syntax. # This is the commit message #20: Updated config.yml # This is the commit message #21: IGVF-35-cypress-circleci Do a build and run of production build.
forresttanaka
added a commit
that referenced
this pull request
Mar 8, 2022
# This is the 1st commit message: IGVF-35-cypress-circleci Try the cypress orb. # This is the commit message #2: Revert "IGVF-35-cypress-circleci" This reverts commit fa1521f. # This is the commit message #3: IGVF-35-cypress-circleci Revert last change and try a different tactic using docker-compose.test.yml. # This is the commit message #4: Revert "IGVF-35-cypress-circleci" This reverts commit 2e7ad9c. # This is the commit message #5: IGVF-35-cypress-circleci Another attempt to run Cypress in CircleCI. # This is the commit message #6: IGVF-35-cypress-circleci Alter previous attempt. # This is the commit message #7: IGVF-35-cypress-circleci Try two docker-compose files; one specifically for cypress. # This is the commit message #8: IGVF-35-cypress-circleci Possibly the wrong command to start Cypress. # This is the commit message #9: IGVF-35-cypress-circleci Try to solve EACCES error for Cypress cache. # This is the commit message #10: IGVF-35-cypress-circleci Try setting environment variable for Cypress in through the docker-compose file. # This is the commit message #11: IGVF-35-cypress-circleci Fix error setting the environment variable from the last fix. # This is the commit message #12: IGVF-35-cypress-circleci Try a different cypress cache directory # This is the commit message #13: IGVF-35-cypress-circleci Everyone seems to recommend a different syntax. Here’s yet another. # This is the commit message #14: IGVF-35-cypress-circleci Downgrading node in case cypress-io/cypress#15025 is correct. # This is the commit message #15: IGVF-35-cypress-circleci Try apt-get for cypress dependencies. # This is the commit message #16: Revert "IGVF-35-cypress-circleci" This reverts commit f7b66a5. # This is the commit message #17: IGVF-35-cypress-circleci Try using the Cypress orb. # This is the commit message #18: IGVF-35-cypress-circleci Start the server before starting the Cypress tests. # This is the commit message #19: IGVF-35-cypress-circleci Correction to last commit. Options can have very subtle effects on required syntax. # This is the commit message #20: Updated config.yml # This is the commit message #21: IGVF-35-cypress-circleci Do a build and run of production build. # This is the commit message #22: IGVF-35-cypress-circleci Try anything.
forresttanaka
added a commit
that referenced
this pull request
Jul 22, 2022
# This is the 1st commit message: Commit Log * New Request API. All server-based requests now use it. * Update the Request class to use DBRequest instead to avoid the name collision with the Javasript built-in Request class. * Rename request.js to db-request.js. * Update merged profiles pages to use the new server-side DBRequest module. * Convert the access-key code to use the new DBRequest module. * Convert logout to use new DBRequest. * Changed all uses of the Fetch class to the new DBRequest class. Removed session-fetch.js. * Redirect to the page the user was viewing *after* signing into the server. * Rseolve merge conflicts with dev. Adjust session storage for keeping redirectTo. * Update outdated comments. * Fix several merging errors. * Complete merge with dev after adding semicolons. Fix the breadcrumbs Jest tests. * Remove now-unneeded files. * Use DBRequest API for loading /profiles. * Comment the last change. * Fix improper use of session instead of cookie on server-side DBRequest. Add new testid props to term collection pages. * Rename the general.js lib Jest test to have “test” in the name. * Rename the Jest test from request.test.js to db-request.test.js to reflect the target file’s name change. * Place fetch option building into its own method. * Fix the sign-in problem caused by not always including the credentials property of fetch options. * Finish the Jest tests for the db-request module. * A little bit of cleanup. * Fix the query-string misspelling that caused login attempts to fail. * Lots of renaming. * Finish documentation and rename request module Jest test. * Correct comments. * Corrected some comments and removed archaic return of uuids from getServerSideProps. * Back this out before merging to dev. * Update unknown object renderer to use new FetchRequest API. # This is the commit message #2: IGVF-200-request Remove slash at the end of backend_url in case that causes a 500 error.
forresttanaka
added a commit
that referenced
this pull request
Jul 26, 2022
# This is the 1st commit message: IGVF-218-prettier Add a prettier checker command and have prettier ignore the cdk directory. # This is the commit message #2: IGVF-218-prettier Add a CLI command to fix files that don’t comply with prettier. # This is the commit message #3: IGVF-218-prettier Try a pre-commit for prettier.
forresttanaka
added a commit
that referenced
this pull request
Jul 26, 2022
# This is the 1st commit message: IGVF-218-prettier Add a prettier checker command and have prettier ignore the cdk directory. # This is the commit message #2: IGVF-218-prettier Add a CLI command to fix files that don’t comply with prettier. # This is the commit message #3: IGVF-218-prettier Try a pre-commit for prettier. # This is the commit message #4: IGVF-218-prettier Test whether I get an error.
forresttanaka
added a commit
that referenced
this pull request
Jul 26, 2022
# This is the 1st commit message: IGVF-218-prettier Add a prettier checker command and have prettier ignore the cdk directory. # This is the commit message #2: IGVF-218-prettier Add a CLI command to fix files that don’t comply with prettier. # This is the commit message #3: IGVF-218-prettier Try a pre-commit for prettier. # This is the commit message #4: IGVF-218-prettier Test whether I get an error. # This is the commit message #5: Another test
forresttanaka
added a commit
that referenced
this pull request
Jul 28, 2022
# This is the 1st commit message: IGVF-218-prettier Add a prettier checker command and have prettier ignore the cdk directory. # This is the commit message #2: IGVF-218-prettier Add a CLI command to fix files that don’t comply with prettier. # This is the commit message #3: IGVF-218-prettier Try a pre-commit for prettier.
forresttanaka
added a commit
that referenced
this pull request
Aug 1, 2022
# This is the 1st commit message: Commit Log * Use the collection components common to all other collection pages on the users collection page. We still need to wait for the collection report page ticket to get merged before we finish this. * Update the individual user page to show more data. # This is the commit message #2: IGVF-28-users Use the rename “lib” directory instead of “libs.” Remove reminder note from app.spec.js. Add table view to users collection page. # This is the commit message #3: IGVF-28-users The user object while not signed in has a lot of missing properties. Make these conditional on the user object page. # This is the commit message #4: IGVF-28-users Add the new testid property in call to CollectionItem on user collection page.
forresttanaka
added a commit
that referenced
this pull request
Aug 1, 2022
# This is the 1st commit message: Commit Log * Use the collection components common to all other collection pages on the users collection page. We still need to wait for the collection report page ticket to get merged before we finish this. * Update the individual user page to show more data. # This is the commit message #2: IGVF-28-users Use the rename “lib” directory instead of “libs.” Remove reminder note from app.spec.js. Add table view to users collection page. # This is the commit message #3: IGVF-28-users The user object while not signed in has a lot of missing properties. Make these conditional on the user object page. # This is the commit message #4: IGVF-28-users Add the new testid property in call to CollectionItem on user collection page. # This is the commit message #5: IGVF-28-users Take care of case where a user’s `lab` property doesn’t exist.
forresttanaka
added a commit
that referenced
this pull request
Aug 1, 2022
# This is the 1st commit message: Commit Log * Use the collection components common to all other collection pages on the users collection page. We still need to wait for the collection report page ticket to get merged before we finish this. * Update the individual user page to show more data. # This is the commit message #2: IGVF-28-users Use the rename “lib” directory instead of “libs.” Remove reminder note from app.spec.js. Add table view to users collection page. # This is the commit message #3: IGVF-28-users The user object while not signed in has a lot of missing properties. Make these conditional on the user object page. # This is the commit message #4: IGVF-28-users Add the new testid property in call to CollectionItem on user collection page. # This is the commit message #5: IGVF-28-users Take care of case where a user’s `lab` property doesn’t exist. # This is the commit message #6: IGVF-28-users Change the order of returned properties in users getServerSideProps() to have more logic.
forresttanaka
added a commit
that referenced
this pull request
Aug 3, 2022
# This is the 1st commit message: Commit Log * Implement the gene collection and object pages. * Add icon and navigation for the genes collection page. Change the name of the object page from [name].js to [geneid].js to better reflect the actual pathnames of gene objects. * Add gene collection page Cypress test. * Updated the gene server-side code to use the FetchRequest API. * Rename the gene object page so we can adapt to path identifiers without change. # This is the commit message #2: IGVF-252-genes Temporary demo data provider setting.
forresttanaka
added a commit
that referenced
this pull request
Aug 3, 2022
# This is the 1st commit message: Commit Log * Implement the gene collection and object pages. * Add icon and navigation for the genes collection page. Change the name of the object page from [name].js to [geneid].js to better reflect the actual pathnames of gene objects. * Add gene collection page Cypress test. * Updated the gene server-side code to use the FetchRequest API. * Rename the gene object page so we can adapt to path identifiers without change. # This is the commit message #2: IGVF-252-genes Temporary demo data provider setting. # This is the commit message #3: IGVF-252-genes Update npm packages.
forresttanaka
added a commit
that referenced
this pull request
Aug 4, 2022
# This is the 1st commit message: IGVF-103-dbxrefs Commit Log * Add a dbxref processor class and React component to display a list of them. The new “gene” directory just lets us test many kinds of dbxrefs and must be deleted before PR. * Add Jest tests. * Fix up comments. * Update temporary gene page to use new FetchRequest module. * Remove the temporary gene page that I used for testing more kinds of dbxrefs. # This is the commit message #2: IGVF-103-dbxrefs Update npm packages.
forresttanaka
added a commit
that referenced
this pull request
Aug 11, 2022
# This is the 1st commit message: IGVF-95-document Commit Log * Initial commit. * Display document thumbnails. # This is the commit message #2: IGVF-95-document Commit Log * Initial commit. * Display document thumbnails. IGVF-95-document Update npm packages. IGVF-95-document Update major framer-motion version. Fix one comment. IGVF-95-document Format preview images when clicking a thumbnail. IGVF-95-document Refactor image thumbnails to its own component. IGVF-95-document Add a close button on the image overlay. # This is the commit message #3: IGVF-95-document Update package-lock.json after rebasing on dev.
forresttanaka
added a commit
that referenced
this pull request
Aug 11, 2022
# This is the 1st commit message: IGVF-95-document Commit Log * Initial commit. * Display document thumbnails. # This is the commit message #2: IGVF-95-document Commit Log * Initial commit. * Display document thumbnails. IGVF-95-document Update npm packages. IGVF-95-document Update major framer-motion version. Fix one comment. IGVF-95-document Format preview images when clicking a thumbnail. IGVF-95-document Refactor image thumbnails to its own component. IGVF-95-document Add a close button on the image overlay. # This is the commit message #3: IGVF-95-document Update package-lock.json after rebasing on dev. # This is the commit message #4: IGVF-95-document Add an initial document table.
forresttanaka
added a commit
that referenced
this pull request
Jan 13, 2023
# This is the 1st commit message: IGVF-343-ui * Try out some background, data, and border colors. * New button module with just three types of buttons instead of eight. The main Button component now displays icon buttons as well, and the Button.Icon component no longer exists. Only the access key modules work with it, so much of the rest of the site crashes because of the lack of Button.Icon. * Intermediate step on the way to converting all buttons to the new paradigm. * Update all remaining buttons to use the updated Button component. * Get rid of more old button type usages. I’m sure we still have plenty more old button type usages. * Finish up button colors. Still having trouble with an infinite loop in Button.Link. * Update the <Button> API to simplify it and add the new type/size functionality. * Update all the buttons to use new Tailwind custom classes. Move all form elements to a new components/form-elements directory. I still have to break apart the form.js file into individual component modules and update their clients to refer to them in their new locations. * Hook up all clients of the form elements to import them from their new location. I still need to get Jest tests working, but will worry about that later. I now need to get `<Select>` objects to use the sm, md, and lg sizes. * Work out the button heights, hopefully for the last time. Update the dark-mode colors. Add an `<AttachedButton>` wrapper component for buttons to appear attached to each other horizontally. * Add sizes matching the buttons for the `<Select>` component. # This is the commit message #2: IGVF-343-ui Get rid of last usage of now-unused “info” button type. # This is the commit message #3: IGVF-343-ui Update npm packages. # This is the commit message #4: IGVF-343-ui Add `selected` button type for attached buttons that show selections. # This is the commit message #5: IGVF-343-ui Implement Select and TextField components.
forresttanaka
added a commit
that referenced
this pull request
May 9, 2023
# This is the 1st commit message: IGVF-340-profile-requests Update npm packages. # This is the commit message #2: IGVF-340-profile-requests Rebuild package-lock.json after merge with dev.
forresttanaka
added a commit
that referenced
this pull request
May 16, 2023
# This is the 1st commit message: IGVF-340-profile-requests Update npm packages. # This is the commit message #2: IGVF-340-profile-requests Rebuild package-lock.json after merge with dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.