IGVF-30 Complete the features for sortable grids. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forresttanaka
added a commit
that referenced
this pull request
Mar 8, 2022
# This is the 1st commit message: IGVF-35-cypress-circleci Try the cypress orb. # This is the commit message #2: Revert "IGVF-35-cypress-circleci" This reverts commit fa1521f. # This is the commit message #3: IGVF-35-cypress-circleci Revert last change and try a different tactic using docker-compose.test.yml. # This is the commit message #4: Revert "IGVF-35-cypress-circleci" This reverts commit 2e7ad9c. # This is the commit message #5: IGVF-35-cypress-circleci Another attempt to run Cypress in CircleCI. # This is the commit message #6: IGVF-35-cypress-circleci Alter previous attempt. # This is the commit message #7: IGVF-35-cypress-circleci Try two docker-compose files; one specifically for cypress. # This is the commit message #8: IGVF-35-cypress-circleci Possibly the wrong command to start Cypress. # This is the commit message #9: IGVF-35-cypress-circleci Try to solve EACCES error for Cypress cache. # This is the commit message #10: IGVF-35-cypress-circleci Try setting environment variable for Cypress in through the docker-compose file. # This is the commit message #11: IGVF-35-cypress-circleci Fix error setting the environment variable from the last fix. # This is the commit message #12: IGVF-35-cypress-circleci Try a different cypress cache directory # This is the commit message #13: IGVF-35-cypress-circleci Everyone seems to recommend a different syntax. Here’s yet another. # This is the commit message #14: IGVF-35-cypress-circleci Downgrading node in case cypress-io/cypress#15025 is correct. # This is the commit message #15: IGVF-35-cypress-circleci Try apt-get for cypress dependencies. # This is the commit message #16: Revert "IGVF-35-cypress-circleci" This reverts commit f7b66a5. # This is the commit message #17: IGVF-35-cypress-circleci Try using the Cypress orb. # This is the commit message #18: IGVF-35-cypress-circleci Start the server before starting the Cypress tests. # This is the commit message #19: IGVF-35-cypress-circleci Correction to last commit. Options can have very subtle effects on required syntax. # This is the commit message #20: Updated config.yml # This is the commit message #21: IGVF-35-cypress-circleci Do a build and run of production build.
forresttanaka
added a commit
that referenced
this pull request
Mar 8, 2022
# This is the 1st commit message: IGVF-35-cypress-circleci Try the cypress orb. # This is the commit message #2: Revert "IGVF-35-cypress-circleci" This reverts commit fa1521f. # This is the commit message #3: IGVF-35-cypress-circleci Revert last change and try a different tactic using docker-compose.test.yml. # This is the commit message #4: Revert "IGVF-35-cypress-circleci" This reverts commit 2e7ad9c. # This is the commit message #5: IGVF-35-cypress-circleci Another attempt to run Cypress in CircleCI. # This is the commit message #6: IGVF-35-cypress-circleci Alter previous attempt. # This is the commit message #7: IGVF-35-cypress-circleci Try two docker-compose files; one specifically for cypress. # This is the commit message #8: IGVF-35-cypress-circleci Possibly the wrong command to start Cypress. # This is the commit message #9: IGVF-35-cypress-circleci Try to solve EACCES error for Cypress cache. # This is the commit message #10: IGVF-35-cypress-circleci Try setting environment variable for Cypress in through the docker-compose file. # This is the commit message #11: IGVF-35-cypress-circleci Fix error setting the environment variable from the last fix. # This is the commit message #12: IGVF-35-cypress-circleci Try a different cypress cache directory # This is the commit message #13: IGVF-35-cypress-circleci Everyone seems to recommend a different syntax. Here’s yet another. # This is the commit message #14: IGVF-35-cypress-circleci Downgrading node in case cypress-io/cypress#15025 is correct. # This is the commit message #15: IGVF-35-cypress-circleci Try apt-get for cypress dependencies. # This is the commit message #16: Revert "IGVF-35-cypress-circleci" This reverts commit f7b66a5. # This is the commit message #17: IGVF-35-cypress-circleci Try using the Cypress orb. # This is the commit message #18: IGVF-35-cypress-circleci Start the server before starting the Cypress tests. # This is the commit message #19: IGVF-35-cypress-circleci Correction to last commit. Options can have very subtle effects on required syntax. # This is the commit message #20: Updated config.yml # This is the commit message #21: IGVF-35-cypress-circleci Do a build and run of production build. # This is the commit message #22: IGVF-35-cypress-circleci Try anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added Jest tests for sortable grids as well as data grids.