Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs.tech: Klayout: tech: Add layer map #151

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

dnltz
Copy link
Contributor

@dnltz dnltz commented Jun 26, 2024

OpenROAD requires the sg13g2.map file to correctly place each layer. Fix this here to not overwrite manually changes in OpenROAD-Flow-Scripts.

@sergeiandreyev
Copy link
Contributor

Hi @dnltz, is it possible to just put the .map file to this repo? in libs.tech/klayout/tech along with .lyt and .lyp files
I'm not sure that's a good idea to have this long relative path in KLayout tech file, referencing another repository / folder

@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024

Hi @dnltz, is it possible to just put the .map file to this repo? in libs.tech/klayout/tech along with .lyt and .lyp files I'm not sure that's a good idea to have this long relative path in KLayout tech file, referencing another repository / folder

The path is actually used by OpenROAD to load the .map file. However, seems like no other PDK is using a .map file ... so maybe this can a workaround until a better solution for the .map file was found?

@gadfort
Copy link
Contributor

gadfort commented Jun 27, 2024

@dnltz we use the layer map file as well (although we are not fully enabled for this PDK yet). https://github.com/siliconcompiler/lambdapdk and https://github.com/siliconcompiler/siliconcompiler

@sergeiandreyev
Copy link
Contributor

there was a suggestion by Matthias Koefferlein (KLayout developer) last year to use the map file instead of modifying the technology .lyt file because the approach inside klayout is not efficient
the question is where to store / have this file

@sergeiandreyev
Copy link
Contributor

I prefer to have it as part of IHP OpenPDK repository, because it's PDK specific data, we set the correct licenses, we're aware of changes and can confirm or reject them, etc.

@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024

I prefer to have it as part of IHP OpenPDK repository, because it's PDK specific data, we set the correct licenses, we're aware of changes and can confirm or reject them, etc.

alright, let me try to get this done without this OpenROAD specific path.

OpenROAD requires the sg13g2.map file to correctly place each layer.
Fix this here to not overwrite manually changes in
OpenROAD-Flow-Scripts.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
This file was copied from the OpenROAD-flow-scripts repository
and should be maintained and kept here.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
OpenROAD-flow-scripts will search and replace for
<lef-files>.*</lef-files>. Therefore, keep it empty in this syntax.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024

@sergeiandreyev with some search and replace magic in ORFS, the following .lyt file works.

@gadfort Are you okay with an empty lef-files tag? Your change broke ORFS ...

@gadfort
Copy link
Contributor

gadfort commented Jun 27, 2024

@dnltz yeah, an empty tag like that works for me.

@sergeiandreyev sergeiandreyev merged commit 8776449 into IHP-GmbH:dev Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants