Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unordered behavior is defined in terms of canvases, but allowed on Collection #1975

Open
azaroth42 opened this issue Feb 24, 2021 · 3 comments · May be fixed by #2304
Open

unordered behavior is defined in terms of canvases, but allowed on Collection #1975

azaroth42 opened this issue Feb 24, 2021 · 3 comments · May be fixed by #2304

Comments

@azaroth42
Copy link
Member

Where the intent is, I believe, that the set of manifests in the collection is unordered, rather than anything to do with those manifests canvases.

Seems like a bug in the description of the behavior value to me. Thanks to sadler in slack for reporting it.

@kirschbombe
Copy link
Contributor

To clarify, unordered is not valid on Manifests then? Is there a use case where someone would have an unordered behavior on a Manifest that did not apply to its Canvases?

@azaroth42
Copy link
Member Author

Oh no, it's valid on both, but defined only in terms of Canvases as the things which are unordered.

e.g. unordered on Collection = Manifests are unordered ; unordered on Manifest = Canvases are unordered

It could (as written) be interpreted that on a Collection, the Canvases in all of the component Manifests are unordered.

@kirschbombe
Copy link
Contributor

Oh, gotcha. The current language didn't at first seem to be ambiguous, so I misread your message above. I'll take a stab at clarifying the language.

@kirschbombe kirschbombe linked a pull request Jun 14, 2024 that will close this issue
kirschbombe added a commit that referenced this issue Jun 14, 2024
@kirschbombe kirschbombe linked a pull request Jun 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants