Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0011 book 3 behavior #198

Merged
merged 43 commits into from
Nov 13, 2020
Merged

0011 book 3 behavior #198

merged 43 commits into from
Nov 13, 2020

Conversation

kirschbombe
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to staging August 6, 2020 20:23 Inactive
@triplingual
Copy link
Contributor

Establishing link with issue #11

@glenrobson glenrobson added the meta: ready-for-editors Ready for Cookbook editor review label Oct 19, 2020
@glenrobson glenrobson marked this pull request as ready for review October 19, 2020 23:01
@glenrobson glenrobson linked an issue Oct 19, 2020 that may be closed by this pull request
@glenrobson
Copy link
Member

Cookbook editor comments:

The cookbook editors note this recipes contains two use cases in one and this may come up in the TRC although the editors are happy to approve it as all use cases match the feature described.

In use case

  • Can you mention unordered in the use case and the situations where this might be used. The recipe mentions individuals, continuous and paged but not unordered. A example where it might be used is a collection of unordered photographs. Its fine to add it as a use case with context but not include an example manifest.

In Restrictions

  • Could you remove the back ticks around Collection, Manifest, Range and Canvas in the Restrictions section.

in Related recipes:

  • Can you remove Book (paging variations) - as this seems to be a link back to itself.
  • Remove [Thumbnails][0012]
  • Remove [Table of contents (ranges) - book chapters][0024]

The cookbook editors are happy to approve the recipe with the changes above.

@kirschbombe
Copy link
Contributor Author

kirschbombe commented Oct 20, 2020

Thank you for the feedback. I'm happy to make the changes above, but have a question about the use case. In discussing the use cases for this recipe, we decided to only include continuous and individuals because the recipe was for behavior variations for book objects. Unordered doesn't fit this use case, so we left it out. I think we'd need to change the focus of the recipe overall to include unordered. I'm happy to do so, but want to make sure this is the intention. Alternatively, I could create a new issue/recipe that focuses on behavior for something like an archival folder.

@glenrobson
Copy link
Member

Thats a good point. The thing that came up in the meeting was that unordeded is mentioned in the restrictions part but no where else. Is there a way to include a reference to it in the use case even if only briefly and maybe point to an unordered / archival recipe?

@glenrobson
Copy link
Member

Issue passed in TRC with no changes requested so I am merging.

@glenrobson glenrobson merged commit 13eafc7 into master Nov 13, 2020
@glenrobson glenrobson deleted the 0011-book-3-behavior branch November 13, 2020 17:52
@triplingual triplingual added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: ready-for-trc Issue is ready for TRC review labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: approved-by-trc Recipe has been approved by the TRC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Book (paging variations)
3 participants