New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtpass doesn't commit deletes to git #81

Closed
hwine opened this Issue Aug 3, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@hwine

hwine commented Aug 3, 2015

When using version 0.9.2, I noticed that the behavior on password deletion is different than in 'pass' cli.

pass delete Foo will both delete the file in git, and commit that deletion.

QTpass will only delete the file in git, but not commit it.

@annejan

This comment has been minimized.

Member

annejan commented Aug 3, 2015

Thanks for finding this!
This will be fixed in version 1.0.1

The git-removal part was not throughly tested (and rushed in) to be honest . .
It currently does a pass git rm Foo (or without pass, just a git rm Foo) and I probably should have looked closer into what pass does . .

@annejan

This comment has been minimized.

Member

annejan commented Aug 3, 2015

In reverse order git log deleting in pass mode and "native" mode.

commit 58d56a86a5f191a72d50f7cc12cda85e1dbe635f
Author: Anne Jan Brouwer <brouwer@annejan.com>
Date:   Tue Aug 4 00:25:06 2015 +0200

     Remove for test/simple using QtPass.

commit 9f66cc9041701e79a5863d5705194921b433449d
Author: Anne Jan Brouwer <brouwer@annejan.com>
Date:   Tue Aug 4 00:24:36 2015 +0200

    Remove test/why not more from store.

annejan added a commit that referenced this issue Aug 3, 2015

Merge branch 'develop'
Fixes: #81
Fixes: #82
@annejan

This comment has been minimized.

Member

annejan commented Aug 3, 2015

This is now in the master branch.
I'll create a 1.0.1 release later this week, when I find the time for it.

@annejan annejan closed this Aug 3, 2015

@hwine

This comment has been minimized.

hwine commented Aug 4, 2015

Sweet! Thanks for the amazingly quick turn!

annejan added a commit that referenced this issue Jun 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment