Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users setup - key colours could be improved #82

Closed
lightonflux opened this issue Aug 3, 2015 · 4 comments
Closed

Users setup - key colours could be improved #82

lightonflux opened this issue Aug 3, 2015 · 4 comments
Assignees

Comments

@lightonflux
Copy link

I really like that qtpass displays colours to indicate ownership or validity.

But the colours are a bit to bright. And especially the black on bright red makes it relatively hard to read.

The colours should be a bit more friendly, so it is easier to read and nicer to look at them.

My suggestion is to use the tango colour palette, because it is friendly, simple and unobtrusive.

http://tango.freedesktop.org/Tango_Icon_Theme_Guidelines

@annejan
Copy link
Member

annejan commented Aug 3, 2015

I'm trying out dark-red background with white text for untrusted.
And dark-red (on standard background) for expired . .
How does that sound to you @lightonflux?
I tried the blue from tango, but that's not clear enough for secret keys, might consider making them bold though. Any UI and UX tips are welcome by the way.

@annejan
Copy link
Member

annejan commented Aug 3, 2015

Sorry about the ugly OS X screenshots, it's my "work" machine.
screen shot 2015-08-03 at 23 55 07
I am assuming that people sharing their public key on keybase.io are OK with them being shown in a screenshot.
screen shot 2015-08-03 at 23 49 43
Looks great in standard KDE too, also tested some other WMs and Windows, and all seems to work well.

@annejan annejan closed this as completed in eef244b Aug 3, 2015
annejan added a commit that referenced this issue Aug 3, 2015
@lightonflux
Copy link
Author

Looks great. Not exactly sure about the exact blue. But MUCH better than before.

Any UI and UX tips are welcome by the way.

Good. We need to get rid of the huge text block. The two lines explaining the colours shouldn't be necessary. It can be condensed in one line that's similar to a legend for a map.

Quick and vague idea:

keys

Also not sure if the top is the best place to explain that. After all the colours help, but are not necessary. Maybe it makes sense to move the explanation below the list.

This needs a bit more thought.

If the colours are off, that is because of redshift. Forgot to disable it.

@annejan annejan reopened this Aug 3, 2015
@annejan
Copy link
Member

annejan commented Aug 3, 2015

Great idea!
The blue from the Tango theme didn't work for me (have to admit I didn't try it bold with those blues).
I'm trying to get a local UI/UX designer involved, re-opened this issue as reminder about the user dialog.

Red looks normal to me.

Am also working on ditching the need for the Note about re-encryption (for the next release).

@annejan annejan self-assigned this Aug 3, 2015
@annejan annejan closed this as completed in 58a5bbd Jun 1, 2016
annejan added a commit that referenced this issue Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants