System Icons on Buttons and Doubleclick on treeView #124
Conversation
…uttons are hidden
|
I'll try this on OSX and Windows as soon as I can. |
|
Okay, i've closed the pull request as i got trouble on gnome and now my Am 19. Dezember 2015 01:16:04 schrieb Anne Jan Brouwer
|
|
Okay, does work. Forget about the last Message |
…uttons are hidden Added delete and enter Key functionality
…ways reminds me of saving to root directory
…king for PGP key before password creation, but this doesn't work so far
|
Ok, i'll keep coding some stuff until someone stops me :-D |
…d entry or a folder
Message when creating a Folder shows absolute path
|
Double click on folders should just open them, will fix tomorrow but won't merge to 1.6 yet. Also looking into OSX and Windows icons. |
jounathaen
force-pushed
the
master
branch
2 times, most recently
from
34830be
to
0a16974
Compare
|
I'm going to try and cherry-pick these changes into a new branch . . |
|
Great! the major changes would be: Icons on Buttons, Dropdown on Add Button (folder or file) and the config layout. The Icons from Термитоz look nice on KDE, I'm looking forward to see them on some other Desktop environment! |
|
The problem with the graphics is that we are currently unsure about compatibility with the GPL |
|
I replaced the icons for free-icons + replaced progressbar for coolest animated gif. You can see the changes in my branch: https://github.com/termitoz/qtpass/tree/futurator-redesign Also i tried to play with some warm-blacky design: https://github.com/termitoz/qtpass/tree/Futurator-redesign-warm-blacky |
|
Nice!! Will try and merge all this stuff tomorrow :) |
|
updated icons etc... (blue variant) |
|
Merged in |
|
Also TODO is detect wether or not system icons are available (not available on OSX at-least) . . |
|
Back on topic of this pull request . . It looks incredibly nice on KDE 5 |
|
Unfortunately there are no system icons available on OSX, still looks pretty good . . Which is not so much a problem as one can set a (local) iconset to use as fallback. |
|
Gnome (Fedora default) |
|
@annejan Not sure if you saw my post in the UI improvements issue but I made some icons for the interface. Can we use our own icons?
|
|
Yes, we can @jsimplicio . . I am currently looking into making it easy to theme though, since I know a lot of people like to have their system-wide icon theme . . and others prefer application specific. I'm thinking of defaulting to system-wide icons when available and when not available use our own set. Also a possibility to change colours from system default to application specific in a simple theming way (see screenshots from @termitoz ) With the redesign of the configuration screen and some more changes it should be relatively easy to make a theming system, where you can simply add a folder of png's and a configuration (ini) file. . . Mostly because I want to keep the base-install clean and possibly provide bundled themes separately. |
|
@annejan Got ya! Anyone started trying to redesign the config screen? |
|
Yes, @jsimplicio the Pull Request starter @jounathaen did a lot of work in that department . . |
|
I'm looking to replace the But can't really find a good one 😢 |
|
@annejan looks better. Is there anything you need some help designing for? Or making these look better ? |
|
All forms of help are welcome, both in designing and just brainstorming. For example, one thing we'll need pretty soon is to put more options into the profile's . . Also some more stuff that was mentioned in earlier issues. PS. Is there a way for you to share the button set you designed for use on OSX and Windows (set of png's or svg's would be ideal). |
|
@annejan Shared the icons in the UI improvements issue |
|
@annejan You should share your ideas for the profiles |
|
@jsimplicio the discussion is in #112 git options should not be global options but maintainable per profile #112 Thanks for the round buttons, I'd really like to have "just the icons" too (as fallback for Win and OSX) for the merge of this pullrequest #124 |
|
@annejan Sorry you were in need of those icons pretty quick. I got your email. Was just busy. Will reply back soon. :) |
|
No worries :) Thanks again for all the hard work . . |
|
@annejan By copy (password) icon do you mean a key? |
|
@jsimplicio either a key or a copy icon .. like .. two documents . . since that is what will be used on FreeDesktop compatible systems . . |
|
@annejan Ah sorry I got that confused. I was just thinking of an old message here I saw a key icon |
The Buttons "Add", "User", ... are now drawn with the system theme default icons and I added some spacing. (looks good on cinnamon 2.8)
Also I added the functionality that a double-click on a item opens the edit window.
Best regards
Jonathan