Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added template hook to category page, after div.primary-featured-post… #1703

Merged
merged 9 commits into from
May 22, 2019

Conversation

megabulk
Copy link

@megabulk megabulk commented May 5, 2019

… and before div.secondary-featured-post

Copy link
Collaborator

@benlk benlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megabulk Please remove package-lock.json and resolve merge conflicts.

@benlk
Copy link
Collaborator

benlk commented May 6, 2019

@joshdarby do you think this new largo_category_after_primary_featured_post filter should be in category.php or in partials/archive-category-primary-feature.php?

@benlk benlk requested a review from joshdarby May 6, 2019 18:18
@benlk benlk added this to the 0.6.4 milestone May 6, 2019
@benlk
Copy link
Collaborator

benlk commented May 6, 2019

Before merge, this will need a notice of the new filters in changelog.md.

@benlk
Copy link
Collaborator

benlk commented May 6, 2019

Also, @megabulk: starting with your work on Largo and the client site, we're going to try having labeled prerelease versions of Largo, as described at #1705. This doesn't affect your PR against Largo, but we will want to make sure that your umbrella repo has an updated Largo version number.

@megabulk
Copy link
Author

megabulk commented May 6, 2019 via email

@joshdarby
Copy link
Collaborator

@benlk

@joshdarby do you think this new largo_category_after_primary_featured_post filter should be in category.php or in partials/archive-category-primary-feature.php?

@benlk Sorry, just saw this. I think it's fine in category.php. There may be some cases where someone uses partials/archive-category-primary-feature.php but doesn't want to include that filter.

@benlk
Copy link
Collaborator

benlk commented May 13, 2019

Then let's resolve conflicts and get this merged. https://gifs.benlk.com/will-ship.gif

We'll need to start the 0.6.4 section in https://github.com/INN/largo/blob/0.5-dev/changelog.md as part of this.

Josh Darby added 3 commits May 13, 2019 17:08
Placed new `do_action( 'largo_category_after_primary_featured_post' );` inside of last `<?php` opening tag
Started new 0.6.4 changes section and added in note for new hooks added to `category.php`, `archive.php`, and `series-landing.php` templates.
@joshdarby
Copy link
Collaborator

@benlk I've updated the changelog to reflect the updates in this PR + start the new 0.6.4 section.

@benlk
Copy link
Collaborator

benlk commented May 14, 2019

LGTM. :shipit:

@benlk benlk merged commit 06cdb06 into WPBuddy:0.5-dev May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants