Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-0.6.3, bump version number to 0.6.4-prerelease #1705

Merged
merged 1 commit into from
May 6, 2019

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented May 6, 2019

I think we should be doing this so that sites that are running a prerelease build of 0.6.4 will have a different version number from sites running a stable 0.6.3 build. The -prerelease in the version number is so that sites running 0.6.4-prerelease will trigger the Largo update functions when they're finally updated to 0.6.4.

The 0.6.4-prerelease string should be treated by version_compare() as less than 0.6.4, according to the documentation for that function.

We're doing this so that sites that are running a prerelease build of 0.6.4 will have a different version number from sites rnning a stable 0.6.3 build. The `-prerelease` in the version number is so that sites running 0.6.4-prerelease will run the Largo update when they're finally updated to 0.6.4.

The `0.6.4-prerelease` string should be treated by [version_compare()](https://www.php.net/manual/en/function.version-compare.php) as less than `0.6.4`, according to the documentation for that function.
@benlk benlk added this to the 0.6.4 milestone May 6, 2019
@benlk benlk requested a review from joshdarby May 6, 2019 18:35
@benlk benlk self-assigned this May 6, 2019
@benlk benlk mentioned this pull request May 6, 2019
65 tasks
@benlk
Copy link
Collaborator Author

benlk commented May 6, 2019

Notes from Slack:

  1. merge this
  2. wait until @megabulk's Largo changes are done and merged
  3. bump version number in Largo to 0.6.4-prerelease.1
  4. have @megabulk's project use that 0.6.4-prerelease.1 for production.

@benlk benlk merged commit d0db10d into 0.5-dev May 6, 2019
@benlk benlk deleted the 1704-0.6.4-prerelease-version-number branch May 6, 2019 18:51
@benlk benlk mentioned this pull request Aug 22, 2019
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant