Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust width of inserted ads inside post content #70

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

joshdarby
Copy link

Changes

This pull request makes the following changes:

  • Adjusts the width of the SCAIP widget areas inside post content so they are the same width as the post content

Screen Shot 2020-03-03 at 12 07 25 PM
Screen Shot 2020-03-03 at 12 07 18 PM

Why

For #68

As for the widget area (called Inserted Ad 2) where we'd like to place the newsletter signup in story posts (likely using the Forms widget), we're having the same issue with the width as we're having in the Inserted Ad 1 widget area where we'd like to include the Read Next widget. I'm thinking, by adjusting the width of those widget areas so they fit inside the story post container, it should resolve the issue (sort of two birds, one stone, I think).

Testing/Questions

Features that this PR affects:

  • SCAIP widget areas inside post content

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?

Steps to test this PR:

  1. Add some widgets to each Inserted Ad Position 1 and Inserted Ad Position 2 widget areas
  2. View on desktop and mobile and make sure the widget area doesn't extend further than the post content

@joshdarby joshdarby merged commit 905a01e into master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants