Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow to assign null AST childs after non-null #259
This feature seems necessary. We shouldn't have a NPE when we set a target with null. But my first reaction was that it is awful to check everywhere if the parameter is null. After reflection, if we want to keep the setters of parents and/or target on the AST, we don't have any choices. So, I'm ok with this PR.
For now, you have only one test in your PR to test a target null but there aren't tests for other checks. It could be interesting to add new tests for all others cases. We know now why we add these check but not necessarily in a few years.
So, can you add tests?