Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] compressed fab outputs should not keep source dirs #537

Closed
oliv3r opened this issue Dec 18, 2023 · 3 comments
Closed

[FEATURE] compressed fab outputs should not keep source dirs #537

oliv3r opened this issue Dec 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliv3r
Copy link

oliv3r commented Dec 18, 2023

While useful to retain the source files when compression of fab outputs is used, it is not needed in regular cases, also we can just unzip the compressed archives. As such, an option just as keep_temporal_files would be useful to be able to set to remove temporary files, having a cleaner output result.

import:
- file: 'JLCPCB'
  definitions:
    _KIBOT_MANF_DIR: 'output/fab/JLCPCB'
    _KIBOT_POS_PRE_TRANSFORM: '[''_kicost_rename'', ''_rot_footprint'']'
@oliv3r oliv3r added the enhancement New feature or request label Dec 18, 2023
set-soft added a commit that referenced this issue Dec 18, 2023
- Is the most common case, so now we move (instead of copy)
- Can be configured using _KIBOT_COMPRESS_MOVE
- Left the JLCPCB BoM and Position outside, they must be uploaded
  separately

Closes #537
@set-soft
Copy link
Member

The above patch moves the files.
Note that now the BoM and Position aren't part of the ZIP file. This is because you must upload them separately.

@oliv3r
Copy link
Author

oliv3r commented Dec 19, 2023

@set-soft makes sense, aren't the BOM and Position files used by the assembly service only anyway? And I suppose you mean 'need to be uploaded to jlpcb assembly service separately anyway'?

@set-soft
Copy link
Member

When you use JLCPCB you must upload the generated .ZIP first and then the BOM and CPL files. You need them separated. I recently found it while doing some adjusts to the rotation filters.

Also note that the other manufacturer outputs doesn't generate BoM and position. So you currently get the same for all, the ZIP contains the gerbers and drill outputs. In the JLCPCB case they offer a "free" PCBA service, so this is really popular and we generate the files, but again separately because they are uploaded separrately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants