-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support for KiCad 8.0 (undocumented) worksheet files #607
Comments
Hi @BetCvR6 !
Looking at the debug output you'll see that even when KiCad GUI tolerates DOS backslashes the command line doesn't:
If you look at the project file you'll see:
A very bad idea, use regular slashes, like you did with the PCB:
|
Hi Salvador, Thanks for your feedback and your suggestions. Right, sorry I didn't think risks with backslashes... I started by remove comments for all outputs but I've the same behaviour for each generated output. I've also made some tests with debug option and I've got same message you mentioned above. Hence, it's certainly because kibot doesn't find my custom worksheet that it loads the default worksheet. For pcb_print outputs, generation still fails and Kibot reports warning : And with debug option, the following complementary error :
For pcb_print outputs, I tried to replace backslashes by slashes to specify worksheet path (with option sheet_reference_layout). The following tests performed correctly: But Kibot returns an error because it fails to find worksheet with this test:
Is there a way to pass a path with slashes to kibot? Thanks. |
This message is from KiCad!
I think this message is clear: Unsupported worksheet version. I have to investigate what's in the new format and add support. |
- sheet_reference_layout - Also added a workaround for people using backslashes (i.e. Windows+WSL) See #607
- Version 20231118 - Not documented in KiCad site See #607
Hi @BetCvR6 ! The 4492611 patch (+ d6d48a5) adds a workaround for backslashes. So the first test passes without changes in the project file. The 2c08f3b add support for the worksheet v20231118 you included in the example. I can't be sure that all files will load because the current KiCad documentation is dated 2023-04-13, so this format isn't documented. The 3rd test: you mention you used a KiCad 7 WKS, but this is used only in the 4th test. I guess you used other files, but I also guess you didn't save them to disk and hence it failed. So now all the tests are working |
Hi Salvador, Greats! Thanks a lot for the quick update! For kibot 1.6.5 docker image I use this : Thanks in advance |
Hi @BetCvR6 ! You'll find information about the docker images in the docs: https://kibot.readthedocs.io/en/latest/usage_with_ci_cd.html For KiCad 8 the last dev images are fetched using the ghcr.io/inti-cmnb/kicad8_auto_full:dev name. After doing a pull ( |
Should cover all the cases where we read the WKSs from the project See INTI-CMNB#719 and INTI-CMNB#607
Hello,
I use Kicad v8.0.1 under Windows 10 and a docker image of KiBot v1.6.5.
I call Kibot from project directory with command "kibot" without parameter.
When I use KiBot to export schematic to pdf with pdf_sch_print (see TEST 1 in config file), my custom worksheet not appears in output document and KiBot uses default Kicad worksheet. But when I export schematic directly from kicad with Plot, generated pdf is correct and use my custom worksheet.
With a custom worksheet created with Kicad 8.0.1, when I try to export pcb layers to pdf with pcb_print (see TEST 2 in config file), KiBot returns the following messages and none pdf is generated :
With a custom worksheet created with Kicad 7.0, I get the same error (see TEST 3 in config file).
However, if I use option "sheet_reference_layout" to set a path to custom worksheet (see TEST 4" in config file) it works and generated pdf uses my custom worksheet!
I think even if this last test works, it's just a way to get around the problem to load custom worksheets. I made several tests but without success. Please let me know if you need any further information.
I add an archive in attachment :
Thanks for your help.
project_test.zip
The text was updated successfully, but these errors were encountered: