Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add option to disable drawings rendering in render_3d #614

Closed
mdeweerd opened this issue Apr 21, 2024 · 6 comments
Closed

[FEATURE] Add option to disable drawings rendering in render_3d #614

mdeweerd opened this issue Apr 21, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@mdeweerd
Copy link

With kibot 1.6.6., KiCAD8 the User.Drawings are rendered, which gives unexpected black lines:

image

The layer was disable in my GUI.

Maybe there is a way to disable this - IHMO this can be inactive by default and potentially be controlled with an option such as show_drawings similar to show_silkscreen.

@mdeweerd mdeweerd added the enhancement New feature or request label Apr 21, 2024
@set-soft
Copy link
Member

Note that this is huge change in KiCad behavior.

KiCad 7:

  • Only one option for comments and drawings
  • Only one option for eco 1 and 2
  • Comments, drawings, eco 1 and eco 2 NOT displayed when using realistic colors

KiCad 8:

  • Separated options for comments and drawings
  • Separated options for eco 1 and 2
  • Comments, drawings, eco 1 and eco 2 displayed when using realistic colors
  • Default is to show them if no option is found in the JSON file

@mdeweerd
Copy link
Author

Thank you for the feedback - that does imply a few changes.

I'ld be find by adding what is needed to "the JSON file". However, I only find notifications.json in the root of the local kicad directory on windows, and packages.json, repository.json in the pcm subdirectories.

I've gone through the preferences for the 3D settings but did not find anything related.

But because I am using docker I guess I need to bind a json file when running in docker.

@set-soft
Copy link
Member

I'm adding the relevant options to KiAuto, but I found KiCad 8 did other changes related to colors

set-soft added a commit that referenced this issue Apr 23, 2024
- Now controlled individually
- Needs KiAuto 2.3.1
- Also added more information about the inconsistent KiCad behavior

See #614
@set-soft
Copy link
Member

The above patch adds more control about what KiCad 8 draws. Needs KiAuto 2.3.1 and should avoid user drawings (added by default by KiCad when the JSON config doesn't explicitly disable them!)

But note that I'm deprecating this output in favor of the Blender output. The KiCad developers said they don't like the idea of having the 3D render in kicad-cli and the behavior of the GUI changes all the time. The 3D render isn't intended to be non-interactive.

To show you just one detail, here is the same test case using different KiCad versions:

drawings_layer
drawings_layer
drawings_layer
drawings_layer

Or using the "realistic" mode:

drawings_real
drawings_real
drawings_real
drawings_real

@mdeweerd
Copy link
Author

I understand that he 3D render is changing accross versions.
Even if not interactive, the 3D snapshot gives a better idea about the depth of components vs. the 2D image (=orthogonal 3D) which is also created using the same method so I guess it would suffer from the same issues.

The 2D image is useful to compare with the real board. I hope that this is not deprecated.

@set-soft
Copy link
Member

Try using an orthographic camera in Blender to get a pseudo-2D image.

The deprecation means that I won't give priority to this output, and won't worry much if it has errors or limitations.

If something is missing in the Blender Export output we should add it, but we can't currently rely on the KiCad renderer, and this is the opinion of the KiCad developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants