Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download-multiple-files-as-one-zip-archive, similar to 3.6.* #338

Closed
eaquigley opened this issue Jul 9, 2014 · 11 comments
Closed

Add download-multiple-files-as-one-zip-archive, similar to 3.6.* #338

eaquigley opened this issue Jul 9, 2014 · 11 comments
Assignees
Labels
Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner

Comments

@eaquigley
Copy link
Contributor


Author Name: Gustavo Durand (@scolapasta)
Original Redmine Issue: 3753, https://redmine.hmdc.harvard.edu/issues/3753
Original Date: 2014-03-24


Elizabeth pointed this out: we also need an ability to select multiple files, via checkboxes, then download them all in one zip file. Similarly to the functionality that already exists in DVN 3.*.


Related issue(s): #28
Redmine related issue(s): 3435


@eaquigley eaquigley added this to the Dataverse 4.0: In Review milestone Jul 9, 2014
@eaquigley eaquigley modified the milestones: Dataverse 4.0: Beta 3, Dataverse 4.0: In Review Jul 15, 2014
@landreev
Copy link
Contributor

Will do this this week, possibly tomorrow.
Retagging the issue "beta 5".

@landreev
Copy link
Contributor

Spoke about this to Elizabeth and Mike the other day. I have the back end for this (can pass multiple file ids to the API file access method and get back a zipped archive); but we decided to postpone adding support for this on the page till beta 8. Since we are likely going to rebuild the page, to accommodate using search for file display. So I'd rather not spend time now trying to figure out how to insert extra checkboxes into the existing file table.

@pdurbin
Copy link
Member

pdurbin commented Oct 31, 2014

I have the back end for this

I'm interested in potentially re-using this code for download of zip files via SWORD in #183.

@landreev
Copy link
Contributor

landreev commented Dec 1, 2014

Back end for this should be working.
The api call for this is /api/access/datafiles (plural datafiles, as opposed to /api/access/datafile access call for a single file).
usage is
/api/access/datafiles/x,y,z...

where x,y,z... is a comma-separated list of datafile ids. you should get back a zip file with the files and a "download manifest", similar to how it works in 3.6. if the total download size goes beyond the configurable limit, an "over the limit..." message is added to the manifest for each file that doesn't fit.

There's still no UI for selecting multiple files. (it still needs to be designed how it's going to work).
The ticket should be given to either Mike or Elizabeth or ... (?) for that.

@kcondon
Copy link
Contributor

kcondon commented Dec 3, 2014

@landreev landreev assigned kcondon and unassigned landreev Dec 8, 2014
@landreev
Copy link
Contributor

landreev commented Dec 8, 2014

Fixed, please retest.

@kcondon
Copy link
Contributor

kcondon commented Dec 10, 2014

OK, seems to work as described, passing to Mike for front end design

@kcondon kcondon added Status: Design UX & UI: Design This issue needs input on the design of the UI and from the product owner and removed Status: QA labels Dec 10, 2014
@kcondon kcondon assigned mheppler and unassigned kcondon Dec 10, 2014
@mheppler
Copy link
Contributor

mheppler commented Jan 8, 2015

We've got a layout mocked up for downloading multiple files.

https://iqssharvard.mybalsamiq.com/projects/files-dataverse40/Dataset%20-%20Files

I'll put together the static version of this and pass it to Leonid for wiring up.

@landreev @scolapasta @eaquigley @kcondon

mheppler added a commit that referenced this issue Jan 8, 2015
…iles table on the Dataset page to be wired up. [ref #338]
@mheppler
Copy link
Contributor

mheppler commented Jan 8, 2015

Added static download button, and multiple select checkboxes to the files table on the Dataset page to be wired up.

Sending to @landreev to wire.

@landreev
Copy link
Contributor

It should be working now;
Please note:

  • there's a separate ticket Mike mentioned, above (Download button issues #1310), for how the "download" button is rendered;
  • you need to have at least 2 files selected before the download link is activated;
  • the "download all files from the dataset" button is disabled on purpose. we'll likely end up implementing this the way it's been done in 3.* instead - with a one-click way to select all the checkboxes

@kcondon
Copy link
Contributor

kcondon commented Jan 22, 2015

OK, works, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature a feature request UX & UI: Design This issue needs input on the design of the UI and from the product owner
Projects
None yet
Development

No branches or pull requests

5 participants