Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization : redesign the architecture to handle metadatablocks #4684

Closed
JayanthyChengan opened this issue May 17, 2018 · 28 comments
Closed

Comments

@JayanthyChengan
Copy link
Contributor

Have to figure out, how internationalization will be handled for the files under scripts/api/data/metadatablocks, so that new dynamic content, like domain metadata fields, can be added to the application and available in all languages.

@pameyer
Copy link
Contributor

pameyer commented May 18, 2018

@JayanthyChengan It may make sense to have internationalization handled separately, but I'd be curious to have your input on how it might fit into something like #4451.

@4tikhonov
Copy link
Contributor

I've managed to get all metadata fields translated in French
screen shot 2018-09-27 at 9 29 36 pm

I can share my solution if the same functionality isn't coming with new release.

@JayanthyChengan
Copy link
Contributor Author

Hi @4tikhonov : Thanks.
I was able to get the output and I committed the code to
https://github.com/scholarsportal/dataverse/tree/4684-metadatablock-internationalization

Will do PR soon after committing french metadata files.

@4tikhonov
Copy link
Contributor

Hi @JayanthyChengan, thanks, I see, it's good idea to have a separate folder for translated properties. I'm looking forward to see it in the master branch, we'll use it for DataverseEU as well.

@4tikhonov
Copy link
Contributor

4tikhonov commented Oct 16, 2018

Hi @4tikhonov : Thanks.
I was able to get the output and I committed the code to
https://github.com/scholarsportal/dataverse/tree/4684-metadatablock-internationalization

Will do PR soon after committing french metadata files.

@JayanthyChengan, we've introduced ISO codes in DataverseEU for all languages we're supporting, can you please also test this properties with current release?
https://github.com/IQSS/dataverse-docker/tree/master/dataversedock/dataverse-property-files
fr-CA here is coming from Scholarsportal, other translations were done by our community.

Also we modified
https://github.com/IQSS/dataverse-docker/blob/master/dataversedock/lang.templates/metadataFragment.xhtml to get translated properties for metadata fields. I don't know if it will be incorporated in the master branch soon so just in the case.

@scolapasta
Copy link
Contributor

@JayanthyChengan thoughts on removing columns from db? It's not ideal to have duplicate info. (alternatively, the code could expect to use the db if the primary language and only use the bundle otherwis; but that seems like possible overkill in logic)

@4tikhonov
Copy link
Contributor

@scolapasta, the ideal solution for DataverseEU is to use controlled vocabularies as properties delivered as microservice with language parameter. We're connecting Dataverse to ELLST multilingual thesaurus now (13 languages, distributed as RDF) to get similar functionality.

@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Dec 4, 2018

@scolapasta - PR #5290 is the latest one with all changes.

@pdurbin
Copy link
Member

pdurbin commented Dec 5, 2018

@JayanthyChengan thanks for all work on this! Shouldn't your pull request include a change to the rst file for http://guides.dataverse.org/en/4.9.4/admin/metadatacustomization.html to explain to creators of custom metadata blocks that they must create not only a TSV file but also a bundle file? Once your pull request is merged, I mean.

@JayanthyChengan
Copy link
Contributor Author

@pdurbin @scolapasta , updated doc/sphinx-guides/source/admin/metadatacustomization.rst in the PR #5290 , please review it.

pdurbin added a commit to scholarsportal/dataverse that referenced this issue Dec 5, 2018
@pdurbin
Copy link
Member

pdurbin commented Dec 5, 2018

@JayanthyChengan I didn't make html but the info you added to about to metadatacustomization.rst looks great! I made a small tweak in a561055 to remove some references to this issue. I put this issue back in code review. Thanks!

@scolapasta scolapasta removed their assignment Dec 6, 2018
@kcondon kcondon self-assigned this Dec 6, 2018
@JayanthyChengan
Copy link
Contributor Author

@kcondon please let me know, if I can answer any of your questions. Thanks

@kcondon
Copy link
Contributor

kcondon commented Dec 13, 2018

@JayanthyChengan Thanks, I have been occupied with other issues but hope to get to this shortly.

@kcondon
Copy link
Contributor

kcondon commented Dec 14, 2018

@JayanthyChengan This looks good and hope to merge shortly but ran into a slight doc issue with unicode char when building pdf format. I'm checking with the team to see whether this is something we need to worry about.

For what it's worth, here is the doc build error for pdf. html works fine:

! Package inputenc Error: Unicode char ṭ (U+1E6D)
(inputenc) not set up for use with LaTeX.

See the inputenc package documentation for explanation.
Type H for immediate help.
...

l.3758 ...age.marathi_(marathi)=Marathi (Marāṭ
hī)
?
! Emergency stop.
...

l.3758 ...age.marathi_(marathi)=Marathi (Marāṭ

@JayanthyChengan
Copy link
Contributor Author

@kcondon replaced with unicode character in this commit
86e5b7c

does this help in pdf generation error?

@kcondon
Copy link
Contributor

kcondon commented Dec 17, 2018

@JayanthyChengan Yes, that did it. Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants