10242 set featured dv via api #10459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
qqmyers
reviewed
Apr 10, 2024
qqmyers
requested changes
Apr 10, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
FWIW: The IT tests didn't run the last build due to the known problem with getting payara right now from the mirror. We should verify that the new tests are still passing once that problem is resolved. (I thought I saw they passed on an earlier build.) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Allows user to add featured collections to a given collection via the api. an additional endpoint was added to allow the user to remove featured collections from a given collection. An endpoint to retrieve the aliases of featured collections for a given Dataverse was also added. It is primarily intended for use by the SPA.
Which issue(s) this PR closes:
Closes #10242 Set featured collections through native api
Special notes for your reviewer:
Suggestions on how to test this: Note that if there are multiple aliases provided in the json file, all collections must be "featurable" for the call to work. If there are errors, only the first error will be included in response
Does this PR introduce a user interface change? If mockups are available, please link/include them here: none
Is there a release notes update needed for this change?: included in PR.
Additional documentation: