IQSS/10462 - Fix when MDC is displayed #10463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
approved these changes
Apr 9, 2024
12 tasks
bikramj
added a commit
to scholarsportal/dataverse
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the dataset page when MDC display is enabled.
Which issue(s) this PR closes:
Closes #10462
Special notes for your reviewer: A trivial fix - DatasetPage has an isDOI() method and the xhtml checked for DatasetPage.doi (lower case).
Suggestions on how to test this: Set :MDCLogPath
and/or
:DisplayMDCMetrics to true and go to a dataset page. (With logging on, the default is for display to be true so setting either MDC related setting results in the bug being visible. See @stevenwinship who say it on his test box.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: Probably needs to be made available ASAP for MDC sites, perhaps as a GDCC bug patch version. (FWIW: There are some Globus download fixes ready for review as well that should get out for those wanting to try Globus).
Additional documentation: