Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7406 access requested refresh #7458

Merged
merged 15 commits into from
Dec 8, 2020
Merged

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Dec 4, 2020

What this PR does / why we need it:
Fixes display/update issues around requesting access to restricted files

Which issue(s) this PR closes:

Closes #7406 and closes #7426

Special notes for your reviewer:
There is some inline style sheet code in the file-download-button-fragment that will hopefully go away when we update prime faces/Bootstrap.
Suggestions on how to test this:
All manner of requesting access with and without terms of access on the dataset page and file page including datasets where requesting access is not allowed.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:
no

Additional documentation:

@sekmiller sekmiller added this to the 5.3 milestone Dec 4, 2020
@coveralls
Copy link

coveralls commented Dec 4, 2020

Coverage Status

Coverage decreased (-0.001%) to 19.398% when pulling cb6e958 on 7406-access-requested-refresh into 0511c8a on develop.

qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this pull request Dec 5, 2020
@pdurbin pdurbin self-assigned this Dec 7, 2020
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The only thing that was a head scratcher to me was the extra inline CSS but I see from the pull request description that it may go away when we update primefaces/bootstrap. I didn't actually run the code but it seems reasonable.

@pdurbin pdurbin removed their assignment Dec 7, 2020
@kcondon kcondon self-assigned this Dec 7, 2020
@kcondon kcondon merged commit 70b6dd2 into develop Dec 8, 2020
@kcondon kcondon deleted the 7406-access-requested-refresh branch December 8, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants