Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7675 update ds success msgs #7707

Merged
merged 5 commits into from
Mar 23, 2021
Merged

7675 update ds success msgs #7707

merged 5 commits into from
Mar 23, 2021

Conversation

sekmiller
Copy link
Contributor

What this PR does / why we need it: Adds a note to the dataset save success message reminding the user to publish their dataset (or submit it for review, as applicable) because a surprising number of users leave their dataset versions in DRAFT.

Which issue(s) this PR closes:

Closes #7675

Special notes for your reviewer:

Suggestions on how to test this:
See that all save dataset success messages have publish/submit reminders that vary by dataset state and user perms.
See google doc attached to the original ticket for wording.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@pdurbin pdurbin self-assigned this Mar 22, 2021
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seems to be straightforward. I didn't run the code myself.

@pdurbin pdurbin removed their assignment Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Success Messaging to indicate that Publishing/Submit for Review is required
4 participants