Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8094 test reports #8404

Closed
wants to merge 2 commits into from
Closed

Conversation

poikilotherm
Copy link
Contributor

@poikilotherm poikilotherm commented Feb 7, 2022

What this PR does / why we need it:
After adding experimental JDK 17 build support, it would be nice to have a easier to read test report than filtering build log output. This PR aims to add them.

Which issue(s) this PR closes:

Relates to #8094

Special notes for your reviewer:
I edited a single Java file to trigger the build in a commit that would still be useful...

Suggestions on how to test this:
Take a look at the failing tests for JDK 17

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.

Is there a release notes update needed for this change?:
Nope.

Additional documentation:
None.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 18.866% when pulling 29abfba on poikilotherm:8094-java17-exp-ci into 8b838f3 on IQSS:develop.

@poikilotherm
Copy link
Contributor Author

Closing - there is no way a pull request from a forked repository is allowed to write a report.

See

You can use the permissions key to add and remove read permissions for forked repositories, but typically you can't grant write access. The exception to this behavior is where an admin user has selected the Send write tokens to workflows from pull requests option in the GitHub Actions settings.

@poikilotherm
Copy link
Contributor Author

It might be possible to work around this by uploading the test results (XML files) as a build artifact and process them with another workflow, using the new workflow_run event.

https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

@poikilotherm poikilotherm deleted the 8094-java17-exp-ci branch March 8, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants