8600 duplicate template #8706
Merged
8600 duplicate template #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scolapasta
requested changes
May 18, 2022
| @@ -46,6 +46,22 @@ public Template findByDeafultTemplateOwnerId(Long ownerId) { | |||
| query.setParameter("ownerId", ownerId); | |||
| return query.getSingleResult(); | |||
| } | |||
|
|
|||
| public List<Template> findByOwnerId(Long ownerId) { | |||
| TypedQuery<Template> query = em.createQuery("select object(o) from Template as o where o.dataverse.id =:ownerId order by o.name", Template.class); | |||
There was a problem hiding this comment.
can we make these named queries?
| return query.getResultList(); | ||
| } | ||
|
|
||
| public List<Template> findOrphan() { |
There was a problem hiding this comment.
Can this be removed, as with the other code?
|
|
||
| https://github.com/IQSS/dataverse/raw/develop/scripts/issues/8600/delete_orphan_templates_8600.sh | ||
|
|
||
| In order to support the script two admin APIs for finding and deleting templates have been added. |
There was a problem hiding this comment.
badly worded ("two" as in one for finding and one for deleting)
scolapasta
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes logic in Copy template that was allowing templates with no dataverse ID to be created. Also adds admin APIs for finding and deleting templates and adds a script for deleting the orphan templates.
Which issue(s) this PR closes:
Closes #8600 Duplicate template seems to create db entries even when cancel.
Special notes for your reviewer: the fix in the cloneTemplate method was fairly simple. Handling the orphan templates added most of the changes
Suggestions on how to test this: the orphan templates are on the template table with Dataverse_id = null
Does this PR introduce a user interface change? If mockups are available, please link/include them here: no
Is there a release notes update needed for this change?: added
Additional documentation: