IQSS/8845 - Avoid creation of extra version in TOA check #8870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and we don't want that in a check of the terms
|
Now that we have the other PR, I presume we can just close this one? @qqmyers tagging to make sure I'm not missing anything |
|
Yes - this was against develop but assuming the other PR is applied to develop as well this should close. That PR has this fix and another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: As of 5.11 a new dataset version was appearing when viewing the DatasetPage for datasets with no draft version. This has various effects from turning on the Delete Draft Dataset menu item to showing the 'ghost' draft in the version table. It may also relate to #8867, #8742.
Which issue(s) this PR closes:
Closes #8845
Special notes for your reviewer: This removes the ghost version creation. I was able to create datasets (some by editing the db) that display this issue while not showing #8867, even if they had fileaccessrequest false and no TofA. So - while this is pretty clearly a bug, I don't know that other issues should be closed without further investigation. (I think it should stop the route we know if that might cause delete from a different version though.)
Suggestions on how to test this: Create a dataset, publish one or more versions, verify that as a logged in user you don't see a ghost draft version in the versions table, don't see a Delete Draft Dataset item in the Edit menu.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: