Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added C/ C++ library ; #9070

Merged
merged 3 commits into from
Oct 27, 2022
Merged

added C/ C++ library ; #9070

merged 3 commits into from
Oct 27, 2022

Conversation

aeonSolutions
Copy link
Contributor

What this PR does / why we need it:
added C/ C++ library; organized chronologically all libraries avail.
Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

organized chronological all libraries avail.
@pdurbin
Copy link
Member

pdurbin commented Oct 21, 2022

@aeonSolutions thanks for the library and the pull request!

You can see a preview here: https://dataverse-guide--9070.org.readthedocs.build/en/9070/api/client-libraries.html#c-c

I see a couple typos that I'm happy to fix next week (when I'm not on a plane ✈️ 😄 ).

organized chronologically all libraries avail.

Hmm, I'm not sure we want this. The libraries were roughly organized by expected popularity (Python first, then R, then the rest) but we have so many now (:tada) that perhaps they should be alphabetical? Not sure. To be determined soon. Thanks again!

@aeonSolutions
Copy link
Contributor Author

aeonSolutions commented Oct 22, 2022

Hi @pdurbin ,
Text has not been checked yet. It was the first type .i will do a grammarly during this weekend .

Reorganizing it alphabetically made sense to me when i read the document. I leave it at your consideration .

I'll be adding the open hardware electronics for the 12bit 1ch ADC during next week. Is now fully tested and working. Currently am designing in kicad a 24bit 6ch ADC that is planned to be added as well. This one will be powerful enough to handle data measurements @ 16Mhz .

@pdurbin pdurbin self-assigned this Oct 27, 2022
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aeonSolutions thanks for the C/C++ library and this pull request!

I think you're right. It's time to establish a sane order for these libraries. 😄 I made it alphabetical.

I also did a sweep through and cleaned up here and there.

Thanks again! Merging!

@pdurbin pdurbin merged commit 526a8c9 into IQSS:develop Oct 27, 2022
@pdurbin pdurbin removed their assignment Oct 27, 2022
@pdurbin pdurbin added this to the 5.12.1 milestone Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants