A quick xhtml-only fix for the "template with custom terms of use" bug #9892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes, or works around the bug by disabling everything inside the file-download-popup-fragment when the page is in CREATE mode.
Which issue(s) this PR closes:
Closes #9825
Special notes for your reviewer:
Going forward, we may want to consider adding some null checks inside the java code to prevent this; it's not entirely impossible that another developer will add some code that will try to call this method on a dataset that doesn't yet have a persistent id for whatever reason - ?
Suggestions on how to test this:
see the linked issue for the steps to reproduce the bug.
edit: would also be prudent to confirm that the file download popup is still working when you are actually downloading files from a dataset that has terms of use. I have tested - but worth confirming.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: