Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket1286 mercury pressure card #448

Merged
merged 3 commits into from
Jan 10, 2020
Merged

Ticket1286 mercury pressure card #448

merged 3 commits into from
Jan 10, 2020

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Dec 16, 2019 •
edited by John-Holt-Tessella
Loading

Description of work

Add config for mercury pressure card

To test

ISISComputingGroup/IBEX#1286

Acceptance criteria

  • All read parameters read the correct value from the labview front panel
  • All set parameters set the correct value onto the labview front panel

Code Review

Functional Tests

  • IOC responds correctly in:
    • Devsim mode
    • Recsim mode
    • Real device, if available
  • Supplementary IOCs (..._0n where n>1) run correctly
  • Log files do not report undefined macros (serach for macLib: macro to find instances of macLib: macro [macro name] is undefined...

Final steps

  • Update the IOC submodule in the main EPICS repo. See Git workflow page for details.
  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Tom-Willemsen Tom-Willemsen mentioned this pull request Dec 16, 2019
Closed
John-Holt-Tessella
John-Holt-Tessella approved these changes Jan 10, 2020
View reviewed changes
MERCURY_ITC/iocBoot/iocMERCURY-IOC-01/config.xml Outdated
@@ -10,6 +10,8 @@
<macro name="VI_TEMP_4" pattern="^[A-Z0-9]+$" description="Suffix of the vi temperature panel, usually '4' or blank for no controller." hasDefault="UNKNOWN" />
<macro name="VI_LEVEL_1" pattern="^[A-Z0-9]+$" description="Suffix of the vi level panel, usually '1' or blank for no controller." hasDefault="UNKNOWN" />
<macro name="VI_LEVEL_2" pattern="^[A-Z0-9]+$" description="Suffix of the vi level panel, usually '2' or blank for no controller." hasDefault="UNKNOWN" />
<macro name="VI_PRESSURE_1" pattern="^[A-Z0-9]+$" description="Suffix of the vi pressure panel, usually '1' or blank for no controller." hasDefault="UNKNOWN" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have a default! probably blank right

@pull-request-size pull-request-size bot added size/L and removed size/S labels Jan 10, 2020
@John-Holt-Tessella John-Holt-Tessella merged commit 7fafcd1 into master Jan 10, 2020
@John-Holt-Tessella John-Holt-Tessella deleted the Ticket1286_mercury_pressure_card branch January 10, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tom-Willemsen @John-Holt-Tessella