-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Personalized resource limits: add project nodes table to store nodes resources 🗃️ #4362
✨Personalized resource limits: add project nodes table to store nodes resources 🗃️ #4362
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4362 +/- ##
=========================================
- Coverage 85.6% 83.4% -2.3%
=========================================
Files 463 844 +381
Lines 22348 37224 +14876
Branches 554 461 -93
=========================================
+ Hits 19138 31054 +11916
- Misses 3092 6054 +2962
+ Partials 118 116 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
301db71
to
092c9f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍 nice that we started to normalize tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
just some thoughts to discuss tomorrow on-site
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments. I would like to take about this with you in person.
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_projects_nodes.py
Show resolved
Hide resolved
874346f
to
91e9357
Compare
91e9357
to
a9909b7
Compare
a9909b7
to
3000ead
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 3000ead and detected 0 issues on this pull request. View more on Code Climate. |
What do these changes do?
Bonus:
Related issue/s
How to test
DevOps Checklist