✨Personalized resources: remove projects to projects nodes table 🗃️ #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
changed the title
matusdrobuliak66
approved these changes
Jun 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #4384 +/- ##
========================================
- Coverage 87.7% 87.2% -0.5%
========================================
Files 567 843 +276
Lines 28104 37186 +9082
Branches 554 461 -93
========================================
+ Hits 24669 32460 +7791
- Misses 3303 4611 +1308
+ Partials 132 115 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GitHK
reviewed
Jun 19, 2023
packages/postgres-database/src/simcore_postgres_database/models/projects_nodes.py
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 4460cda and detected 0 issues on this pull request. View more on Code Climate. |
This was referenced Jun 19, 2023
GitHK
approved these changes
Jun 19, 2023
pcrespov
approved these changes
Jun 19, 2023
sanderegg
deleted the
personalized-resources/remove-projects-to-projects-nodes
branch
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR essentially simplifies the database. The original design was keeping a separate table for the mapping between projects and nodes.
It appears that node_uuid are not unique. A few tests, and also the meta-programming rely on the fact that node_uuid are copied to keep a trace. Therefore the node_uuid cannot be used as a primary key in the DB. Further analysis show that there is currently no need to share a node.
The uniqueness of a node is defined by both its project_uuid and node_uuid. This is the current constraint that is also found in the comp_tasks table.
this partially reverts #4362
Bonus:
postgres-database is fully SqlAchemy 2.0 warning free
Related issue/s
How to test
DevOps Checklist