-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Personalized resource limits: only allow specific groups to override resources #4417
✨Personalized resource limits: only allow specific groups to override resources #4417
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4417 +/- ##
========================================
+ Coverage 83.1% 85.3% +2.1%
========================================
Files 963 1000 +37
Lines 40927 42817 +1890
Branches 1012 1026 +14
========================================
+ Hits 34018 36526 +2508
+ Misses 6675 6056 -619
- Partials 234 235 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e09fc37
to
5d2bd9e
Compare
abe4460
to
7b8ad90
Compare
8ac212a
to
d94bd41
Compare
✔️ |
bac51c1
to
761bf9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!
packages/postgres-database/src/simcore_postgres_database/models/groups_extra_properties.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/utils/dask.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/users/_handlers.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_groups_extra_properties.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! 👍
Code Climate has analyzed commit 0f722e7 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, I read over it and it looks very promissing :)
If you want feel free to add a DevOps
Warning/Tasks to remove the previous service overwrites we had in the DB (for Taylor etc.) once this propagates, if you want
|
What do these changes do?
General idea:
PUT /projects/{project_uuid}/nodes/{node_id}/resources
only usable by users within these groupsGET /me/permissions
that returns a list of users permissions:Bonus:
Related issue/s
How to test
groups extra properties
DevOps Checklist